From 1b680e6c5395f50103337d2dce0c5c3e34de6b10 Mon Sep 17 00:00:00 2001 From: Andrew Bonney Date: Wed, 17 Apr 2024 08:18:31 +0100 Subject: [PATCH] Remove RabbitMQ restart when changing policy My assumption is that this restart only exists for historical reasons or in order to force client re-connection and re-definition of queues to match this policy. Unfortunately the current task only executes on a single RabbitMQ node when part of a cluster, so it is ineffective in forcing reconnection. From a brief review at least when shifting from non-HA to HA this also isn't required as queues are immediately updated to reflect the new policy. Given no clear reason for the task to be present, I'm removing it ahead of making changes to the default HA policy. Change-Id: I956abe68d4d7921a4e87ae5a7694d49546bdde94 (cherry picked from commit cfb1c281510700d507806cb54f9f7843a1f082c1) --- tasks/rabbitmq_post_install.yml | 8 -------- 1 file changed, 8 deletions(-) diff --git a/tasks/rabbitmq_post_install.yml b/tasks/rabbitmq_post_install.yml index 4eb51069..613f9a74 100644 --- a/tasks/rabbitmq_post_install.yml +++ b/tasks/rabbitmq_post_install.yml @@ -88,14 +88,6 @@ - rabbitmq-config - rabbitmq-cluster -- include_tasks: - file: rabbitmq_restart.yml - apply: - tags: rabbitmq-config - when: rabbitmq_policy is changed - tags: - - rabbitmq-config - # This is being done because the rabbitctl command used by the module # is not very effective at returning proper status codes for failure # and the module does not error detection. until we can go upstream