openstack/openstack-ansible-rabbitmq_server
Code Issues Proposed changes

Start rabbitmq service when config is in place

Browse Source 
rabbitmq is started three times:

1st time in rabbitmq_install with default config
2nd time in rabbitmq_set_cookie with default config
3rd time in rabbitmq_post_install with OSA config

however, there is no need for that and we can remove the 1st one and
the 2nd as it uses a default config which might break deployments
(e.g. if number of threads is limited through cgroups)

Change-Id: Iaef3b91d2a555bf0681f4a7d018d6d93e93889b4
Signed-off-by: Manuel Buil <mbuil@suse.com>
This commit is contained in:
Manuel Buil 2018-10-24 18:08:55 +02:00
parent 628125a940
commit 89b475890a
3 changed files with 4 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tasks/rabbitmq_install.yml
View File

@ -40,7 +40,3 @@
- rabbitmq-upgrade - rabbitmq-upgrade
- rabbitmq-policy-file - rabbitmq-policy-file
- rabbitmq_server-config - rabbitmq_server-config
- include_tasks: rabbitmq_started.yml
tags:
- rabbitmq_server-config

5
tasks/rabbitmq_post_install.yml
View File

@ -71,6 +71,9 @@
tags: tags:
- rabbitmq-config - rabbitmq-config
- include_tasks: rabbitmq_restart.yml
when: rabbit_config is changed or rabbitmq_plugin is changed or cookie_set is changed
- name: Apply rabbitmq policies - name: Apply rabbitmq policies
rabbitmq_policy: rabbitmq_policy:
node: "rabbit@{{ ansible_hostname }}" node: "rabbit@{{ ansible_hostname }}"
@ -85,7 +88,7 @@
- rabbitmq-cluster - rabbitmq-cluster
- include_tasks: rabbitmq_restart.yml - include_tasks: rabbitmq_restart.yml
when: rabbit_config is changed or rabbitmq_plugin is changed or rabbitmq_policy is changed when: rabbitmq_policy is changed
# This is being done because the rabbitctl command used by the module # This is being done because the rabbitctl command used by the module
# is not very effective at returning proper status codes for failure # is not very effective at returning proper status codes for failure

9
tasks/rabbitmq_set_cookie.yml
View File

@ -21,12 +21,3 @@
owner: rabbitmq owner: rabbitmq
group: rabbitmq group: rabbitmq
register: cookie_set register: cookie_set
- include_tasks: rabbitmq_stopped.yml
when:
- cookie_set is changed
- include_tasks: rabbitmq_started.yml
when:
- cookie_set is changed