Optimise apt cache update task

The update of the apt cache and the package installation
can all be handled in a single task by providing the
package action plugin with the right parameters. This
removes an extra task to optimise execution.

The minimum Ansible version is raised to 2.2 due to a
known bug [1] in Ansible's apt module which does not
update the cache properly if the cache update and the
install are combined in a single task.

[1] https://github.com/ansible/ansible-modules-core/issues/1497

Change-Id: I171c4d7d6e051b69106156df797ea96d6184014a
This commit is contained in:
Jesse Pretorius 2017-04-21 16:57:49 +01:00
parent 5a150eee9b
commit 7cfea8b6b5
2 changed files with 3 additions and 8 deletions

View File

@ -18,7 +18,7 @@ galaxy_info:
description: Rsyslog log client setup
company: Rackspace
license: Apache2
min_ansible_version: 1.6.6
min_ansible_version: 2.2
platforms:
- name: Ubuntu
versions:

View File

@ -13,17 +13,12 @@
# See the License for the specific language governing permissions and
# limitations under the License.
- name: Ensure apt cache is up to date
apt:
update_cache: yes
cache_valid_time: "{{ cache_timeout }}"
when:
- ansible_pkg_mgr == 'apt'
- name: Install rsyslog packages
package:
pkg: "{{ item }}"
state: "{{ rsyslog_client_package_state }}"
update_cache: "{{ (ansible_pkg_mgr == 'apt') | ternary('yes', omit) }}"
cache_valid_time: "{{ (ansible_pkg_mgr == 'apt') | ternary(cache_timeout, omit) }}"
register: install_packages
until: install_packages|success
retries: 5