Update patch set 1
Patch Set 1: Workflow-1 (3 comments) Should the yum/apt install sections be broken into separate task files and included, or do you prefer to have them all in one .yml. Having them in one feels a little messy, but the trade off is having more eyes on the code when changes happen. We should talk about updating tests to include tests for RPM/yum based distros. Patch-set: 1 Label: Workflow=-1
This commit is contained in:
parent
ac167f3c20
commit
dfc3bbac88
73
9a39e191cb1454a1b07d2972d54d792c73319e4a
Normal file
73
9a39e191cb1454a1b07d2972d54d792c73319e4a
Normal file
@ -0,0 +1,73 @@
|
||||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7a5de9d1_7d989fc0",
|
||||
"filename": "defaults/main.yml",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 22,
|
||||
"author": {
|
||||
"id": 20038
|
||||
},
|
||||
"writtenOn": "2016-01-29T23:32:51Z",
|
||||
"side": 1,
|
||||
"message": "I feel this format will allow us to more easily add distros later.",
|
||||
"range": {
|
||||
"startLine": 20,
|
||||
"startChar": 0,
|
||||
"endLine": 22,
|
||||
"endChar": 45
|
||||
},
|
||||
"revId": "9a39e191cb1454a1b07d2972d54d792c73319e4a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7a5de9d1_5db92314",
|
||||
"filename": "tasks/rsyslog_server_install.yml",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 72,
|
||||
"author": {
|
||||
"id": 20038
|
||||
},
|
||||
"writtenOn": "2016-01-29T23:32:51Z",
|
||||
"side": 1,
|
||||
"message": "without default([]) being included, ansible fails by complaining there needs to be a list. With_items changes how the when statement is applied, according to docs.",
|
||||
"range": {
|
||||
"startLine": 72,
|
||||
"startChar": 2,
|
||||
"endLine": 72,
|
||||
"endChar": 77
|
||||
},
|
||||
"revId": "9a39e191cb1454a1b07d2972d54d792c73319e4a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7a5de9d1_7ddf3f69",
|
||||
"filename": "tasks/rsyslog_server_pre_install.yml",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 26,
|
||||
"author": {
|
||||
"id": 20038
|
||||
},
|
||||
"writtenOn": "2016-01-29T23:32:51Z",
|
||||
"side": 1,
|
||||
"message": "the syslog user isn\u0027t present in CentOS 7 by default, we need to make this step more modular, or possibly have it performed post-install.",
|
||||
"range": {
|
||||
"startLine": 25,
|
||||
"startChar": 0,
|
||||
"endLine": 26,
|
||||
"endChar": 55
|
||||
},
|
||||
"revId": "9a39e191cb1454a1b07d2972d54d792c73319e4a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue
Block a user