Update patch set 1

Patch Set 1: Code-Review-1

(4 comments)

I tried to find any references in oslo.config, and I don't think it has been ever implemented. For config sources I don't see castelan - only env or url https://opendev.org/openstack/oslo.config/src/branch/master/oslo_config/sources

I don't think we should discuss implementation in openstack-ansible until things are done in oslo.

And what comes to implementation in oslo, I'd actually prefer having it without 2 extra files, that actually can be implemented inside same config.

I.e in Nova there's already key_manager section https://docs.openstack.org/nova/latest/configuration/config.html#key-manager (but it's used for encryption at rest rather then auth storage afaik)

Patch-set: 1
Reviewer: Gerrit User 28619 <28619@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1

86cc15b4310407f877fa70c1a6489125e9a2efde

@@ -1,5 +1,51 @@
 {
   "comments": [
+    {
+      "key": {
+        "uuid": "58388bf5_894e2086",
+        "filename": "specs/stein/protecing-plaintext-configs.rst",
+        "patchSetId": 1
+      },
+      "lineNbr": 43,
+      "author": {
+        "id": 28619
+      },
+      "writtenOn": "2021-04-27T05:59:46Z",
+      "side": 1,
+      "message": ".. code-block:: text\n\n    [DEFAULT]\n    config_source \u003d secrets\n\n    [secrets]\n    driver\u003dcastellan\n    config_file\u003dcastellan.conf\n    mapping_file\u003dmapping.conf",
+      "range": {
+        "startLine": 32,
+        "startChar": 0,
+        "endLine": 43,
+        "endChar": 30
+      },
+      "revId": "86cc15b4310407f877fa70c1a6489125e9a2efde",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "86ea0ebe_54803d49",
+        "filename": "specs/stein/protecing-plaintext-configs.rst",
+        "patchSetId": 1
+      },
+      "lineNbr": 72,
+      "author": {
+        "id": 28619
+      },
+      "writtenOn": "2021-04-27T05:59:46Z",
+      "side": 1,
+      "message": "please use code-block as well here",
+      "range": {
+        "startLine": 52,
+        "startChar": 1,
+        "endLine": 72,
+        "endChar": 48
+      },
+      "revId": "86cc15b4310407f877fa70c1a6489125e9a2efde",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
     {
       "key": {
         "uuid": "dbe63c61_7017a7b1",
@@ -22,6 +68,52 @@
       "revId": "86cc15b4310407f877fa70c1a6489125e9a2efde",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "1c8243a1_0340a583",
+        "filename": "specs/stein/protecing-plaintext-configs.rst",
+        "patchSetId": 1
+      },
+      "lineNbr": 122,
+      "author": {
+        "id": 28619
+      },
+      "writtenOn": "2021-04-27T05:59:46Z",
+      "side": 1,
+      "message": "extra?",
+      "range": {
+        "startLine": 122,
+        "startChar": 74,
+        "endLine": 122,
+        "endChar": 75
+      },
+      "revId": "86cc15b4310407f877fa70c1a6489125e9a2efde",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "a3bd9793_424ca7c8",
+        "filename": "specs/stein/protecing-plaintext-configs.rst",
+        "patchSetId": 1
+      },
+      "lineNbr": 254,
+      "author": {
+        "id": 28619
+      },
+      "writtenOn": "2021-04-27T05:59:46Z",
+      "side": 1,
+      "message": "It\u0027s 404 and I think this spec has been never implemented according to the https://blueprints.launchpad.net/oslo.config/+spec/protect-plaintext-passwords (or it hasn\u0027t been referenced during implementation)",
+      "range": {
+        "startLine": 254,
+        "startChar": 4,
+        "endLine": 254,
+        "endChar": 94
+      },
+      "revId": "86cc15b4310407f877fa70c1a6489125e9a2efde",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
     }
   ]
 }