ansible-lint: Fix yaml[truthy]

Change-Id: I5922d4c23d89977bd88622027070be736d3f10da
Signed-off-by: Ivan Anfimov <lazekteam@gmail.com>
This commit is contained in:
Ivan Anfimov committed 2025-11-22 16:27:40 +00:00
1 parent b62ce91a0f
commit 258a0df737
13 files changed
+34 -51

No files matched your search

@@ -157,7 +157,7 @@ to automatically recover a node or an entire environment.
.. code-block:: shell-session
# openstack-ansible openstack.osa.galera_server -e galera_force_bootstrap=True --tags galera_server-config
# openstack-ansible openstack.osa.galera_server -e galera_force_bootstrap=true --tags galera_server-config
You can additionally define a different bootstrap node through
``galera_server_bootstrap_node`` variable, in case current bootstrap node is in
@@ -256,13 +256,13 @@ In order to achieve that we need:
container_skel:
az1_containers:
properties:
is_nest: True
is_nest: true
az2_containers:
properties:
is_nest: True
is_nest: true
az3_containers:
properties:
is_nest: True
is_nest: true
#. Now you can leverage ``group_vars`` file to apply a variable to all
containers and bare metal hosts in AZ.
@@ -274,7 +274,6 @@ In order to achieve that we need:
az_name: az1
cinder_storage_availability_zone: "{{ az_name }}"
Deploying with no component type per host (or more than one)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@@ -340,7 +339,6 @@ To omit a component from a deployment, you can use one of several options:
you specify the component to run directly on a host by using the ``is_metal``
property, a container is created for this component.
Having SSH network different from OpenStack Management network
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@@ -121,7 +121,7 @@ This check does not do YAML syntax validation, though it will fail if there
are unparseable errors.
Writing debug logs
~~~~~~~~~~~~~~~~~~~
~~~~~~~~~~~~~~~~~~
The ``--debug/-d`` parameter allows writing of a detailed log file for
debugging the inventory script's behavior. The output is written to
@@ -131,7 +131,6 @@ The ``inventory.log`` file is appended to, not overwritten.
Like ``--check``, this flag is not invoked when running from ansible.
Running with tox
~~~~~~~~~~~~~~~~
@@ -146,8 +145,8 @@ tox.ini file in that directory with following content:
envlist = generate_inventory
[testenv]
skip_install = True
usedevelop = True
skip_install = true
usedevelop = true
allowlist_externals =
bash
+1 -1
View File
@@ -69,7 +69,7 @@ Example - adding ``aarch64`` nodes to an ``x86_64`` deployment
.. code:: yaml
[scheduler]
image_metadata_prefilter = True
image_metadata_prefilter = true
[filter_scheduler]
image_properties_default_architecture = x86_64
@@ -16,7 +16,6 @@ to custom ports which completely disables the ability to use them in such deploy
In order to work around such limitations, starting from 2023.1 (Antelope) release,
it is possible to have domain-based or path-based endpoints instead.
Configuring domain-based endpoints (recommended)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@@ -29,7 +28,6 @@ As a prerequisite for this type of setup you need to ensure that corresponding
`A` or `CNAME` records are present for your domain. Also, you need to ensure
having a valid wildcard or SAN certificates for public/internal endpoints.
HAProxy configuration
---------------------
@@ -79,7 +77,7 @@ We need to make adjustments to each HAProxy service definition to:
.. code:: yaml
haproxy_keystone_service_overrides:
haproxy_backend_only: True
haproxy_backend_only: true
haproxy_map_entries:
- name: base_domain
entries:
@@ -87,7 +85,7 @@ We need to make adjustments to each HAProxy service definition to:
- "identity.{{ internal_lb_vip_address }} keystone_service-back"
haproxy_nova_api_compute_service_overrides:
haproxy_backend_only: True
haproxy_backend_only: true
haproxy_map_entries:
- name: base_domain
entries:
@@ -95,13 +93,12 @@ We need to make adjustments to each HAProxy service definition to:
- "compute.{{ internal_lb_vip_address }} nova_api_os_compute-back"
haproxy_nova_novnc_console_service_overrides:
haproxy_backend_only: True
haproxy_backend_only: true
haproxy_map_entries:
- name: base_domain
entries:
- "novnc.{{ external_lb_vip_address }} nova_novnc_console-back"
Service configuration
---------------------
@@ -126,7 +123,6 @@ Below you can find an example for defining endpoints for Keystone and Nova:
nova_service_adminuri: "{{ openstack_service_adminuri_proto }}://compute.{{ internal_lb_vip_address }}"
nova_novncproxy_base_uri: "{{ nova_novncproxy_proto }}://novnc.{{ external_lb_vip_address }}"
Using Let's Encrypt
-------------------
@@ -139,7 +135,7 @@ So your Let's Encrypt configuration may look like this:
.. code:: yaml
haproxy_ssl_letsencrypt_enable: True
haproxy_ssl_letsencrypt_enable: true
haproxy_ssl_letsencrypt_email: "root@{{ external_lb_vip_address }}"
haproxy_ssl_letsencrypt_domains:
- "{{ external_lb_vip_address }}"
@@ -171,7 +167,6 @@ example below:
- "identity.{{ internal_lb_vip_address }}"
- "compute.{{ internal_lb_vip_address }}"
You also might want to adjust HSTS headers defined by
``haproxy_security_headers_csp`` variable. While default rules do allow
subdomains out of the box, you might want to restrict records a bit more to
@@ -194,7 +189,6 @@ disallow access on arbitrary ports.
haproxy_security_frame_ancestors_records:
- "{{ external_lb_vip_address }}
Configuring path-based endpoints
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@@ -222,7 +216,6 @@ are VNC consoles for VMs (to be implemented with
`blueprint <https://blueprints.launchpad.net/nova/+spec/novnc-base-url-respect-extra-params>`_),
Magnum (`bug report <https://launchpad.net/bugs/2083168>`) and Ceph Rados Gateway.
HAProxy configuration
---------------------
@@ -269,20 +262,19 @@ HAProxy map population with a respective condition, for example:
.. code:: yaml
haproxy_keystone_service_overrides:
haproxy_backend_only: True
haproxy_backend_only: true
haproxy_map_entries:
- name: base_regex
entries:
- "^/identity keystone_service-back"
haproxy_nova_api_compute_service_overrides:
haproxy_backend_only: True
haproxy_backend_only: true
haproxy_map_entries:
- name: base_regex
entries:
- "^/compute nova_api_os_compute-back"
Service configuration
---------------------
@@ -421,6 +413,5 @@ as an example:
/compute/v2/+: openstack_compute_api_v21_legacy_v2_compatible
/compute/v2.1/+: openstack_compute_api_v21
We suggest referring to each service api-paste.ini for more details
on how to properly configure overrides.
+1 -4
View File
@@ -4,7 +4,6 @@ Running as non-root user
Deployers do not have to use ``root`` user accounts on deploy or target hosts.
This approach works out of the box by leveraging `Ansible privilege escalation`_.
Deployment hosts
~~~~~~~~~~~~~~~~
@@ -41,7 +40,6 @@ guidelines:
script still should be done either as the ``root`` user or escalate
privileges using ``sudo`` or ``su``.
Destination hosts
~~~~~~~~~~~~~~~~~
@@ -62,8 +60,7 @@ There are also couple of additional things which you might want to consider:
.. code-block:: shell-session
export ANSIBLE_BECOME="True"
export ANSIBLE_BECOME="true"
#. Override Ansible temporary path if LXC containers are used. The ansible
connection from the physical host to the LXC container passes
@@ -76,7 +76,6 @@ This functionality can be changed by overriding the list of headers in
``haproxy_security_headers`` variable in the
``/etc/openstack_deploy/user_variables.yml`` file.
Content Security Policy (CSP)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@@ -100,13 +99,12 @@ you use the ``Content-Security-Policy-Report-Only`` header, instead of
but does not enforce the policy.
To set the CSP policy to report only by overriding the
``haproxy_security_headers_csp_report_only`` variable to ``True`` in the
``haproxy_security_headers_csp_report_only`` variable to ``true`` in the
``/etc/openstack_deploy/user_variables.yml`` file:
.. code-block:: yaml
haproxy_security_headers_csp_report_only: True
haproxy_security_headers_csp_report_only: true
Reporting Violations
--------------------
@@ -250,7 +250,7 @@ http-01 challenge requests.
.. code-block:: shell-session
haproxy_ssl: true
haproxy_ssl_letsencrypt_enable: True
haproxy_ssl_letsencrypt_enable: true
haproxy_ssl_letsencrypt_email: "email.address@example.com"
TLS for HAProxy Internal Virtual IP (VIP)
@@ -299,14 +299,14 @@ following variable:
.. code-block:: yaml
openstack_service_backend_ssl: True
openstack_service_backend_ssl: true
There is also an option to enable it only for individual services:
.. code-block:: yaml
keystone_backend_ssl: True
neutron_backend_ssl: True
keystone_backend_ssl: true
neutron_backend_ssl: true
By default, self-signed certificates will be used to secure traffic but
user-provided certificates are also supported.
+1 -1
View File
@@ -13,7 +13,7 @@ global_overrides:
- policy:
name: default
index: 0
default: True
default: true
swift-proxy_hosts:
aio1:
ip: {{ bootstrap_host_public_address }}
@@ -169,7 +169,7 @@
#
# Level: storage_policies (required)
# Contains storage policies. Minimum one policy. One policy must include
# the 'index: 0' and 'default: True' options.
# the 'index: 0' and 'default: true' options.
#
# Level: policy (required)
# Contains a storage policy. Define for each policy.
@@ -204,7 +204,7 @@
#
# Option: default (conditionally required, boolean)
# Defines the default policy. One policy must include this option
# with a 'True' value.
# with a 'true' value.
#
# Option: deprecated (optional, boolean)
# Defines a deprecated policy.
@@ -228,12 +228,12 @@
# - policy:
# name: gold
# index: 0
# default: True
# default: true
# - policy:
# name: silver
# index: 1
# repl_number: 3
# deprecated: True
# deprecated: true
# - policy:
# name: ec10-4
# index: 2
+4 -4
View File
@@ -32,13 +32,13 @@ component_skel:
container_skel:
pod1_containers:
properties:
is_nest: True
is_nest: true
pod2_containers:
properties:
is_nest: True
is_nest: true
pod3_containers:
properties:
is_nest: True
is_nest: true
pod4_containers:
properties:
is_nest: True
is_nest: true
@@ -1,7 +1,7 @@
---
haproxy_drain: True
haproxy_ssl_all_vips: True
haproxy_drain: true
haproxy_ssl_all_vips: true
haproxy_bind_external_lb_vip_interface: eth20
haproxy_bind_internal_lb_vip_interface: eth1
haproxy_bind_external_lb_vip_address: "*"
@@ -704,7 +704,7 @@
# iscsi_ip_address: 172.29.244.5
# san_login: username
# san_password: password
# san_thin_provision: True
# san_thin_provision: true
#
#
# Example:
@@ -793,7 +793,7 @@
# generic:
# share_backend_name: GENERIC
# share_driver: manila.share.drivers.generic.GenericShareDriver
# driver_handles_share_servers: True
# driver_handles_share_servers: true
# service_instance_flavor_id: 100
# service_image_name: manila-service-image
# service_instance_user: manila