openstack/openstack-ansible
Code Issues Proposed changes

Only gather facts when necessary

Browse Source 
We only need to gather facts once per host, and only
when it's required. Doing it more often just slows
down the deployment.

Change-Id: Id11654218819a544c2b91c636c00374165b16559
This commit is contained in:
Jesse Pretorius
2017-07-12 16:07:57 +01:00
committed by Jesse Pretorius (odyssey4me)
parent 0bc21886e4
commit 6519bd6cc9
5 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
playbooks/os-cinder-install.yml
View File

@@ -15,7 +15,7 @@
- name: Prepare MQ/DB services - name: Prepare MQ/DB services
hosts: cinder_all hosts: cinder_all
gather_facts: "{{ gather_facts | default(True) }}" gather_facts: no
user: root user: root
environment: "{{ deployment_environment_variables | default({}) }}" environment: "{{ deployment_environment_variables | default({}) }}"
tags: tags:
@@ -96,6 +96,7 @@
# a long time if executed against a large inventory. # a long time if executed against a large inventory.
- name: Refresh local facts after all software changes are made - name: Refresh local facts after all software changes are made
hosts: cinder_all hosts: cinder_all
gather_facts: no
max_fail_percentage: 20 max_fail_percentage: 20
user: root user: root
environment: "{{ deployment_environment_variables | default({}) }}" environment: "{{ deployment_environment_variables | default({}) }}"

3
playbooks/os-glance-install.yml
View File

@@ -15,7 +15,7 @@
- name: Prepare MQ/DB services - name: Prepare MQ/DB services
hosts: glance_all hosts: glance_all
gather_facts: "{{ gather_facts | default(True) }}" gather_facts: no
user: root user: root
environment: "{{ deployment_environment_variables | default({}) }}" environment: "{{ deployment_environment_variables | default({}) }}"
tags: tags:
@@ -80,6 +80,7 @@
# a long time if executed against a large inventory. # a long time if executed against a large inventory.
- name: Refresh local facts after all software changes are made - name: Refresh local facts after all software changes are made
hosts: glance_all hosts: glance_all
gather_facts: no
max_fail_percentage: 20 max_fail_percentage: 20
user: root user: root
environment: "{{ deployment_environment_variables | default({}) }}" environment: "{{ deployment_environment_variables | default({}) }}"

3
playbooks/os-keystone-install.yml
View File

@@ -15,7 +15,7 @@
- name: Prepare MQ/DB services - name: Prepare MQ/DB services
hosts: keystone_all hosts: keystone_all
gather_facts: "{{ gather_facts | default(True) }}" gather_facts: no
user: root user: root
environment: "{{ deployment_environment_variables | default({}) }}" environment: "{{ deployment_environment_variables | default({}) }}"
tags: tags:
@@ -148,6 +148,7 @@
# a long time if executed against a large inventory. # a long time if executed against a large inventory.
- name: Finalise data migrations if required - name: Finalise data migrations if required
hosts: keystone_all hosts: keystone_all
gather_facts: no
max_fail_percentage: 20 max_fail_percentage: 20
user: root user: root
environment: "{{ deployment_environment_variables | default({}) }}" environment: "{{ deployment_environment_variables | default({}) }}"

2
playbooks/os-neutron-install.yml
View File

@@ -30,7 +30,7 @@
- name: Prepare MQ/DB services - name: Prepare MQ/DB services
hosts: neutron_all hosts: neutron_all
gather_facts: "{{ gather_facts | default(True) }}" gather_facts: no
max_fail_percentage: 20 max_fail_percentage: 20
user: root user: root
environment: "{{ deployment_environment_variables | default({}) }}" environment: "{{ deployment_environment_variables | default({}) }}"

3
playbooks/os-nova-install.yml
View File

@@ -15,7 +15,7 @@
- name: Prepare MQ/DB services - name: Prepare MQ/DB services
hosts: nova_conductor hosts: nova_conductor
gather_facts: "{{ gather_facts | default(True) }}" gather_facts: no
user: root user: root
environment: "{{ deployment_environment_variables | default({}) }}" environment: "{{ deployment_environment_variables | default({}) }}"
tags: tags:
@@ -132,6 +132,7 @@
# a long time if executed against a large inventory. # a long time if executed against a large inventory.
- name: Refresh local facts after all software changes are made - name: Refresh local facts after all software changes are made
hosts: nova_all hosts: nova_all
gather_facts: no
max_fail_percentage: 20 max_fail_percentage: 20
user: root user: root
environment: "{{ deployment_environment_variables | default({}) }}" environment: "{{ deployment_environment_variables | default({}) }}"