From a8d7a07c4931eed1847f439f64a30b220a4ab4c9 Mon Sep 17 00:00:00 2001 From: Travis Truman Date: Tue, 1 Mar 2016 17:02:09 -0500 Subject: [PATCH] [DOC] Describe core reviewer team responsibilities Change-Id: I8813ffe03dbbeb18fcc9808e44578cf43ad9cadf --- doc/source/developer-docs/core-reviewers.rst | 71 ++++++++++++++++++++ doc/source/developer-docs/index.rst | 1 + 2 files changed, 72 insertions(+) create mode 100644 doc/source/developer-docs/core-reviewers.rst diff --git a/doc/source/developer-docs/core-reviewers.rst b/doc/source/developer-docs/core-reviewers.rst new file mode 100644 index 0000000000..c2e5da6f30 --- /dev/null +++ b/doc/source/developer-docs/core-reviewers.rst @@ -0,0 +1,71 @@ +`Home `_ OpenStack-Ansible Developer Documentation + +Core Reviewers +============== + +General Responsibilities +------------------------ + +The `OpenStack-Ansible Core Reviewer Team`_ is responsible for many aspects of +the OpenStack-Ansible project. These include, but are not limited to: + + * Mentor community contributors in solution design, testing, and the review + process + * Actively reviewing patch submissions, considering whether the patch: + - is functional + - fits the use-cases and vision of the project + - is complete in terms of testing, documentation, and release notes + - takes into consideration upgrade concerns from previous versions + * Assist in bug triage and delivery of bug fixes + * Curating the gate and triaging failures + * Maintaining accurate, complete, and relevant documentation + * Ensuring the level of testing is adequate and remains relevant as features + are added + * Answering questions and participating in mailing list discussions + * Interfacing with other OpenStack teams + +In essence, core reviewers share the following common ideals: + + * They share responsibility in the project’s success in its `mission`_. + * They value a healthy, vibrant, and active developer and user community. + * They have made a long-term, recurring time investment to improve the + project. + * They spend their time doing what needs to be done to ensure the project's + success, not necessarily what is the most interesting or fun. + * A core reviewer’s responsibility doesn’t end with merging code. + +.. _OpenStack-Ansible Core Reviewer Team: https://review.openstack.org/#/admin/groups/490,members +.. _mission: https://governance.openstack.org/reference/projects/openstackansible.html#mission + +Core Reviewer Expectations +-------------------------- + +Members of the core reviewer team are expected to: + + * Attend and participate in the weekly IRC meetings + * Monitor and participate in-channel at #openstack-ansible + * Monitor and participate in OpenStack-Ansible discussions on the mailing list + * Participate in related design summit sessions at the OpenStack Summits + * Review patch submissions actively and consistently + +Please note in-person attendance at design summits, mid-cycles, and other code +sprints is not a requirement to be a core reviewer. The team will do its best +to facilitate virtual attendance at all events. Travel is not to be taken +lightly, and we realize the costs involved for those who attend these events. + +Code Merge Responsibilities +--------------------------- + +While everyone is encouraged to review changes, members of the core reviewer +team have the ability to +2/-2 and +A changes to these repositories. This is +an extra level of responsibility not to be taken lightly. Correctly merging +code requires not only understanding the code itself, but also how the code +affects things like documentation, testing, upgrade impacts and interactions +with other projects. It also means you pay attention to release milestones and +understand if a patch you are merging is marked for the release, especially +critical during the feature freeze. + + +-------------- + +.. include:: navigation.txt diff --git a/doc/source/developer-docs/index.rst b/doc/source/developer-docs/index.rst index af3d324a3b..9387bc7090 100644 --- a/doc/source/developer-docs/index.rst +++ b/doc/source/developer-docs/index.rst @@ -14,6 +14,7 @@ Contents: playbooks extending contribute + core-reviewers additional-roles inventory