ansible-lint: Fix yaml[truthy]

Change-Id: I9842f3cbefb9c760df8aacd12e3f5af76ae8819f Signed-off-by: Ivan Anfimov <lazekteam@gmail.com>
2025-11-27 21:08:14 +00:00
parent 7323d633f0
commit cb3f3e60c4
11 changed files with 48 additions and 48 deletions
--- a/scripts/openstack-ansible.rc
+++ b/scripts/openstack-ansible.rc
@@ -16,7 +16,7 @@ export LC_ALL="${LC_ALL:-C.UTF-8}"

 export OSA_CONFIG_DIR="${OSA_CONFIG_DIR:-/etc/openstack_deploy}"

-export ANSIBLE_RETRY_FILES_ENABLED="${ANSIBLE_RETRY_FILES_ENABLED:-False}"
+export ANSIBLE_RETRY_FILES_ENABLED="${ANSIBLE_RETRY_FILES_ENABLED:-false}"

 export ANSIBLE_INVENTORY="${ANSIBLE_INVENTORY:-OSA_INVENTORY_PATH/dynamic_inventory.py,OSA_INVENTORY_PATH/inventory.ini,${OSA_CONFIG_DIR}/inventory.ini}"

@@ -39,7 +39,7 @@ export ANSIBLE_GATHERING="${ANSIBLE_GATHERING:-smart}"
 export ANSIBLE_CACHE_PLUGIN="${ANSIBLE_CACHE_PLUGIN:-jsonfile}"
 export ANSIBLE_CACHE_PLUGIN_CONNECTION="${ANSIBLE_CACHE_PLUGIN_CONNECTION:-${OSA_CONFIG_DIR}/ansible_facts}"
 export ANSIBLE_CACHE_PLUGIN_TIMEOUT="${ANSIBLE_CACHE_PLUGIN_TIMEOUT:-86400}"
-export ANSIBLE_INJECT_FACT_VARS="${ANSIBLE_INJECT_FACT_VARS:-False}"
+export ANSIBLE_INJECT_FACT_VARS="${ANSIBLE_INJECT_FACT_VARS:-false}"

 if [[ "${ANSIBLE_CACHE_PLUGIN}" == "memcached" ]];then
  if ! echo stats | nc -w 1 $(echo ${ANSIBLE_CACHE_PLUGIN_CONNECTION}|awk -F',' '{print $1}'|sed 's/:/ /') > /dev/null; then
@@ -47,16 +47,16 @@ if [[ "${ANSIBLE_CACHE_PLUGIN}" == "memcached" ]];then
  fi
 fi

-export ANSIBLE_HOST_KEY_CHECKING="${ANSIBLE_HOST_KEY_CHECKING:-False}"
+export ANSIBLE_HOST_KEY_CHECKING="${ANSIBLE_HOST_KEY_CHECKING:-false}"
 export ANSIBLE_TIMEOUT="${ANSIBLE_TIMEOUT:-5}"
 export ANSIBLE_TRANSPORT="${ANSIBLE_TRANSPORT:-openstack.osa.ssh}"
-export ANSIBLE_SSH_PIPELINING="${ANSIBLE_SSH_PIPELINING:-True}"
+export ANSIBLE_SSH_PIPELINING="${ANSIBLE_SSH_PIPELINING:-true}"
 export ANSIBLE_SSH_RETRIES="${ANSIBLE_SSH_RETRIES:-5}"
 export ANSIBLE_SSH_ARGS="${ANSIBLE_SSH_ARGS:--C -o ControlMaster=auto -o ControlPersist=300}"
 export ANSIBLE_PIPELINING="${ANSIBLE_SSH_PIPELINING}"
 export ANSIBLE_FORKS="${ANSIBLE_FORKS:-OSA_ANSIBLE_FORKS}"

-export ANSIBLE_FORCE_HANDLERS="${ANSIBLE_FORCE_HANDLERS:-True}"
+export ANSIBLE_FORCE_HANDLERS="${ANSIBLE_FORCE_HANDLERS:-true}"
 export ANSIBLE_PYTHON_INTERPRETER="${ANSIBLE_PYTHON_INTERPRETER:-OSA_ANSIBLE_PYTHON_INTERPRETER}"

 export ANSIBLE_TRANSFORM_INVALID_GROUP_CHARS="${ANSIBLE_TRANSFORM_INVALID_GROUP_CHARS:-always}"
--- a/tests/roles/bootstrap-host/defaults/main.yml
+++ b/tests/roles/bootstrap-host/defaults/main.yml
@@ -148,7 +148,7 @@ bootstrap_host_ip_path: "{{ bootstrap_host_network_utils[ansible_facts['pkg_mgr'
 # This does not run by default, but gate-check-commit and the OSA gate jobs
 # enable this because it is needed for RAX nodepool instances
 bootstrap_host_data_disk_device_detect: "{{ lookup('env', 'BOOTSTRAP_HOST_DETECT_DATA_DISK') |
-                                            default(False, True) }}"
+                                            default(false, true) }}"

 # Specify the secondary disk device to use. When the data disk is in use, no NOT
 # set the full path to the device. IE: "/dev/xvde" should be "xvde".
--- a/tests/roles/bootstrap-host/tasks/check-requirements.yml
+++ b/tests/roles/bootstrap-host/tasks/check-requirements.yml
@@ -20,7 +20,7 @@
      tags:
        - check-operating-system
  when:
-    - (check_operating_system | default(True)) | bool
+    - (check_operating_system | default(true)) | bool
  tags:
    - check-operating-system

--- a/tests/roles/bootstrap-host/templates/user_variables.aio.yml.j2
+++ b/tests/roles/bootstrap-host/templates/user_variables.aio.yml.j2
@@ -14,7 +14,7 @@
 # limitations under the License.

 ## General options
-debug: True
+debug: true

 ## Installation method for OpenStack services
 install_method: "{{ bootstrap_host_install_method }}"
@@ -97,7 +97,7 @@ cinder_wsgi_threads: 1
 cinder_wsgi_buffer_size: 16384
 cinder_osapi_volume_workers_max: 1

-## cloudkitty
+## CloudKitty
 cloudkitty_wsgi_processes: 1
 cloudkitty_wsgi_threads: 1

@@ -118,7 +118,7 @@ manila_wsgi_threads: 1
 manila_osapi_share_workers: 2
 manila_wsgi_buffer_size: 65535

-## mistral
+## Mistral
 mistral_wsgi_processes: 1
 mistral_wsgi_threads: 1

@@ -263,12 +263,12 @@ lxc_container_bind_mounts:
    container_directory: "/opt/cache/files"

 ## Always setup tempest, the resources for it, then execute tests
-tempest_install: yes
-tempest_run: yes
-rally_install: yes
+tempest_install: true
+tempest_run: true
+rally_install: true

 # Do a gateway ping test once the tempest role creates it
-tempest_network_ping_gateway: yes
+tempest_network_ping_gateway: true

 {% if nodepool_dir.stat.exists %}
 # Copy /etc/pip.conf into containers to get mirrors for wheels
--- a/tests/roles/bootstrap-host/templates/user_variables_horizon.yml.j2
+++ b/tests/roles/bootstrap-host/templates/user_variables_horizon.yml.j2
@@ -18,4 +18,4 @@ tempest_test_includelist_horizon:

 tempest_tempest_conf_overrides_horizon:
  dashboard:
-    disable_ssl_certificate_validation: True
+    disable_ssl_certificate_validation: true
--- a/tests/roles/bootstrap-host/templates/user_variables_manila.yml.j2
+++ b/tests/roles/bootstrap-host/templates/user_variables_manila.yml.j2
@@ -36,17 +36,17 @@ tempest_tempest_conf_overrides_manila:
    min_api_microversion: "2.0"
    # Set this to the highest microversion supported by the openstack release
    max_api_microversion: "2.67"
-    run_consistency_group_tests: False
-    run_snapshot_tests: False
-    capability_snapshot_support: True
-    multitenancy_enabled: False
-    run_shrink_tests: True
-    run_extend_tests: True
-    multi_backend: False
+    run_consistency_group_tests: false
+    run_snapshot_tests: false
+    capability_snapshot_support: true
+    multitenancy_enabled: false
+    run_shrink_tests: true
+    run_extend_tests: true
+    multi_backend: false
    enable_protocols: nfs
-    run_ipv6_tests: False
+    run_ipv6_tests: false
    share_creation_retry_number: 2
-    suppress_errors_in_cleanup: True
+    suppress_errors_in_cleanup: true
    capability_storage_protocol: NFS
    enable_ip_rules_for_protocols: nfs
    image_with_share_tools: manila-service-image
@@ -54,14 +54,14 @@ tempest_tempest_conf_overrides_manila:
    endpoint_type: internalURL

 tempest_images:
-  - url: "https://download.cirros-cloud.net/0.6.2/cirros-0.6.2-x86_64-disk.img"
-    checksum: "c8fc807773e5354afe61636071771906"
+  - url: "https://download.cirros-cloud.net/0.6.3/cirros-0.6.3-x86_64-disk.img"
+    checksum: "87617e24a5e30cb3b87fda8c0764838f"
    format: "qcow2"
    name: "cirros"
    visibility: community
    tags:
      - managed_by_tempest
-  - url: "http://tarballs.openstack.org/manila-image-elements/images/manila-service-image-master.qcow2"
+  - url: "https://tarballs.opendev.org/openstack/manila-image-elements/images/manila-service-image-master.qcow2"
    format: "qcow2"
    name: "manila-service-image"
    visibility: public
@@ -74,10 +74,10 @@ manila_backends:
    cephfs_cluster_name: ceph
    cephfs_conf_path: /etc/ceph/ceph.conf
    cephfs_ganesha_server_ip: {{ bootstrap_host_management_address }}
-    cephfs_ganesha_server_is_remote: False
+    cephfs_ganesha_server_is_remote: false
    cephfs_protocol_helper_type: NFS
-    driver_handles_share_servers: False
+    driver_handles_share_servers: false
    share_backend_name: CEPHFSNFS1
    share_driver: manila.share.drivers.cephfs.driver.CephFSDriver
-    ganesha_rados_store_enable: False
+    ganesha_rados_store_enable: false
    ganesha_rados_store_pool_name: manila_data
--- a/tests/roles/bootstrap-host/templates/user_variables_octavia.yml.j2
+++ b/tests/roles/bootstrap-host/templates/user_variables_octavia.yml.j2
@@ -19,11 +19,11 @@ octavia_octavia_conf_overrides:
    health_update_threads: 2
    stats_update_threads: 2

-octavia_enable_anti_affinity: False
+octavia_enable_anti_affinity: false
 octavia_loadbalancer_topology: SINGLE

-octavia_ssh_enabled: True
-octavia_legacy_policy: True
+octavia_ssh_enabled: true
+octavia_legacy_policy: true
 octavia_amp_vcpu: 2
 octavia_amp_ram: 512
 tempest_service_available_octavia: true
--- a/tests/roles/bootstrap-host/templates/user_variables_stepca.yml.j2
+++ b/tests/roles/bootstrap-host/templates/user_variables_stepca.yml.j2
@@ -3,7 +3,7 @@

 # SSL setup
 haproxy_ssl: true
-haproxy_ssl_letsencrypt_enable: True
+haproxy_ssl_letsencrypt_enable: true
 haproxy_ssl_letsencrypt_certbot_server: "https://127.0.0.1:8889/acme/acme-osa/directory"

 # openstack_hosts role should ensure that everthing trusts the Step-CA roots
--- a/tests/roles/bootstrap-host/templates/user_variables_tls.yml.j2
+++ b/tests/roles/bootstrap-host/templates/user_variables_tls.yml.j2
@@ -17,12 +17,12 @@
 openstack_service_publicuri_proto: https
 openstack_service_adminuri_proto: https
 openstack_service_internaluri_proto: https
-galera_require_secure_transport: True
-haproxy_ssl: True
-haproxy_ssl_all_vips: True
-rabbitmq_management_ssl: True
-openstack_service_backend_ssl: True
-openstack_service_accept_both_protocols: True
+galera_require_secure_transport: true
+haproxy_ssl: true
+haproxy_ssl_all_vips: true
+rabbitmq_management_ssl: true
+openstack_service_backend_ssl: true
+openstack_service_accept_both_protocols: true
 # Keep keystone proto set to 'http'. This way we can ensure that
 # `openstack_service_accept_both_protocols` works as expected.
 keystone_service_publicuri_proto: http
@@ -33,9 +33,9 @@ keystone_service_internaluri_proto: http
 openstack_service_publicuri_proto: http
 openstack_service_adminuri_proto: http
 openstack_service_internaluri_proto: http
-haproxy_ssl: False
-haproxy_ssl_all_vips: False
-rabbitmq_management_ssl: False
-openstack_service_backend_ssl: False
-openstack_service_accept_both_protocols: False
+haproxy_ssl: false
+haproxy_ssl_all_vips: false
+rabbitmq_management_ssl: false
+openstack_service_backend_ssl: false
+openstack_service_accept_both_protocols: false
 {% endif %}
--- a/zuul.d/playbooks/pre-osa-aio.yml
+++ b/zuul.d/playbooks/pre-osa-aio.yml
@@ -44,7 +44,7 @@
        SETUP_ARA: 'true'
      when:
        - "'upgrade' not in action"
-        - osa_pre_run_bootstrap | default(True)
+        - osa_pre_run_bootstrap | default(true)

    - name: Run bootstrap-aio script # noqa: no-changed-when
      become: true
@@ -64,4 +64,4 @@
        - "'upgrade' not in action"
        - action != 'linters'
        - action != 'shastest'
-        - osa_pre_run_bootstrap | default(True)
+        - osa_pre_run_bootstrap | default(true)
--- a/zuul.d/playbooks/run.yml
+++ b/zuul.d/playbooks/run.yml
@@ -18,7 +18,7 @@
        skip_bootstrap:
          # NOTE(logan): ARA is already installed in the gate environment by the
          # pre-osa-aio pre-run playbook
-          SETUP_ARA: False # noqa: yaml[truthy]
+          SETUP_ARA: false
          # NOTE(logan): The project is bootstrapped in the pre playbook so the
          # bootstrapping can be skipped here
          SKIP_OSA_RUNTIME_VENV_BUILD: 1