From db8e6c9078dfd272fa2e8bc34231470e8eff2344 Mon Sep 17 00:00:00 2001 From: Gaudenz Steinlin Date: Tue, 9 Jan 2018 10:45:40 +0100 Subject: [PATCH] Stable keepalived priorities The calculation of the keepalived priority depended on the set of hosts in the ansible_play_hosts variable. This meant that priorites changed when the playbook was limited to only run on a subset of the hosts in the "haproxy" group (eg. when reinstalling just one node). This change replaces ansible_play_hosts by groups["haproxy"] so that the priority calculation is stable as long as the set of haproxy nodes does not change. It also simplifies the priority calculation without changeing the result. This change does not change the configuration in case the playbook is run without --limit and ensures that the configuration does not change if it is run with --limit. Change-Id: I378351954fbed7b1fc31303c60e4575ddad9cf1d (cherry picked from commit 78ed74957dfbd1bb151d0e6b5187fa0c263881ad) --- playbooks/vars/configs/keepalived_haproxy.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/playbooks/vars/configs/keepalived_haproxy.yml b/playbooks/vars/configs/keepalived_haproxy.yml index 26b0e1aa7a..a56c348e5d 100644 --- a/playbooks/vars/configs/keepalived_haproxy.yml +++ b/playbooks/vars/configs/keepalived_haproxy.yml @@ -40,15 +40,15 @@ keepalived_scripts: # If you have more than 5 keepalived nodes, you should build your own script # (handling master and backups servers), and replace in keepalived_instances: -# priority: "{{ ((play_hosts|length-play_hosts.index(inventory_hostname))*100)-((play_hosts|length-play_hosts.index(inventory_hostname))*50) }}" +# priority: "{{ (groups['haproxy']|length-groups['haproxy'].index(inventory_hostname)*50 }}" # by -# priority: "{{ (play_hosts.index(inventory_hostname) == 0) | ternary('100','50') }}" +# priority: "{{ (groups['haproxy'].index(inventory_hostname) == 0) | ternary('100','50') }}" keepalived_instances: external: interface: "{{ haproxy_keepalived_external_interface | default(management_bridge) }}" - state: "{{ (play_hosts.index(inventory_hostname) == 0) | ternary('MASTER', 'BACKUP') }}" + state: "{{ (groups['haproxy'].index(inventory_hostname) == 0) | ternary('MASTER', 'BACKUP') }}" virtual_router_id: "{{ haproxy_keepalived_external_virtual_router_id | default ('10') }}" - priority: "{{ ((play_hosts|length-play_hosts.index(inventory_hostname))*100)-((play_hosts|length-play_hosts.index(inventory_hostname))*50) }}" + priority: "{{ (groups['haproxy']|length-groups['haproxy'].index(inventory_hostname))*50 }}" authentication_password: "{{ haproxy_keepalived_authentication_password }}" vips: - "{{ haproxy_keepalived_external_vip_cidr | default('169.254.1.1/24') }} dev {{ haproxy_keepalived_external_interface | default(management_bridge) }}" @@ -57,9 +57,9 @@ keepalived_instances: - pingable_check_script internal: interface: "{{ haproxy_keepalived_internal_interface | default(management_bridge) }}" - state: "{{ (play_hosts.index(inventory_hostname) == 0) | ternary('MASTER', 'BACKUP') }}" + state: "{{ (groups['haproxy'].index(inventory_hostname) == 0) | ternary('MASTER', 'BACKUP') }}" virtual_router_id: "{{ haproxy_keepalived_internal_virtual_router_id | default ('11') }}" - priority: "{{ ((play_hosts|length-play_hosts.index(inventory_hostname))*100)-((play_hosts|length-play_hosts.index(inventory_hostname))*50) }}" + priority: "{{ (groups['haproxy']|length-groups['haproxy'].index(inventory_hostname))*50 }}" authentication_password: "{{ haproxy_keepalived_authentication_password }}" track_scripts: - haproxy_check_script