From ebd76388a73f45105cf29c53759ed06efe41a6c3 Mon Sep 17 00:00:00 2001 From: Mohammed Naser Date: Wed, 27 Jun 2018 10:47:17 -0400 Subject: [PATCH] Stop setting a user to the symbolic link There is no point in setting an owner and group for a symbolic link for the logs, only 2 roles do those and they cause issues for systems such as CentOS and require workarounds for SUSE. All the other roles work fine without them so we don't need to use those anymore. Change-Id: I781c901bf0a22790e609600b32eaabb36b82f983 --- playbooks/common-tasks/os-log-dir-setup.yml | 2 -- playbooks/os-molteniron-install.yml | 2 -- playbooks/os-swift-install.yml | 4 ---- 3 files changed, 8 deletions(-) diff --git a/playbooks/common-tasks/os-log-dir-setup.yml b/playbooks/common-tasks/os-log-dir-setup.yml index 5d8b331094..110ae73ee5 100644 --- a/playbooks/common-tasks/os-log-dir-setup.yml +++ b/playbooks/common-tasks/os-log-dir-setup.yml @@ -36,8 +36,6 @@ file: src: "{{ item.src }}" dest: "{{ item.dest }}" - owner: "{{ item.owner|default(omit) }}" - group: "{{ item.group|default(omit) }}" state: "link" force: "yes" with_items: "{{ log_dirs|default([]) }}" diff --git a/playbooks/os-molteniron-install.yml b/playbooks/os-molteniron-install.yml index ec0cdf3fbf..30fa46b0cb 100644 --- a/playbooks/os-molteniron-install.yml +++ b/playbooks/os-molteniron-install.yml @@ -27,8 +27,6 @@ log_dirs: - src: "/openstack/log/{{ inventory_hostname }}-molteniron" dest: "/var/log/molteniron" - owner: "syslog" - group: "syslog" - include: common-tasks/unbound-clients.yml static: no when: diff --git a/playbooks/os-swift-install.yml b/playbooks/os-swift-install.yml index 641ed2ed5a..06745ed762 100644 --- a/playbooks/os-swift-install.yml +++ b/playbooks/os-swift-install.yml @@ -27,10 +27,6 @@ log_dirs: - src: "/openstack/log/{{ inventory_hostname }}-swift" dest: "/var/log/swift" - owner: "syslog" - # NOTE(hwoarang) The syslog user on openSUSE belongs to the 'users' - # group. There is no dedicated syslog group. - group: "{{ (ansible_pkg_mgr == 'zypper') | ternary ('users', 'syslog') }}" - include: common-tasks/unbound-clients.yml static: no when: