From 7e21b7c15c6bc9e7f4d01d1f71ed87152a1f5470 Mon Sep 17 00:00:00 2001 From: Jean-Philippe Evrard Date: Wed, 18 Jul 2018 15:03:58 +0200 Subject: [PATCH] Remove useless group var Since we moved to install tempest from pip packages, this variable can go away: The tempest_git_repo group var is applied when: - The user builds tempest from source instead of from pip packages - The user wants to use developer mode for tempest. For the first case, any override in user space of the user (extra var, group var) would override the group var value, making it completely useless. For the second case, if a deployer wants to use developer mode, this var would override the defaults of the role, which would probably be an inconvenience for the deployer: the deployer would then need to override tempest_developer_constraints, or override the tempest_git_repo itself. That inconvenience can be removed if the group_var is removed. Change-Id: Iec8973105686d448b0284cbaeab625a897066664 --- inventory/group_vars/utility_all.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/inventory/group_vars/utility_all.yml b/inventory/group_vars/utility_all.yml index 07e884f7c1..41bc767d73 100644 --- a/inventory/group_vars/utility_all.yml +++ b/inventory/group_vars/utility_all.yml @@ -59,7 +59,6 @@ tempest_log_dir: /var/log/utility tempest_venv_tag: "{{ openstack_release }}" tempest_venv_download_url: "{{ venv_base_download_url }}/tempest-{{ openstack_release }}-{{ ansible_architecture | lower }}.tgz" tempest_venv_bin: "/openstack/venvs/tempest-{{ tempest_venv_tag }}/bin" -tempest_git_repo: "{{ openstack_repo_git_url }}/tempest" # This sets the tempest group to the utility group tempest_main_group: utility_all