Update patch set 3

Patch Set 3: Code-Review-1

(1 comment)

Looks pretty good to me, but I'd like to see the reno updated

Patch-set: 3
Label: Code-Review=-1
This commit is contained in:
Gerrit User 15334 2019-08-19 13:03:19 +00:00 committed by Gerrit Code Review
parent 274a99f933
commit 1efe6a0520
1 changed files with 27 additions and 0 deletions

View File

@ -0,0 +1,27 @@
{
"comments": [
{
"key": {
"uuid": "7faddb67_485c664a",
"filename": "releasenotes/notes/indexpage-ed235f8665f398d7.yaml",
"patchSetId": 3
},
"lineNbr": 1,
"author": {
"id": 15334
},
"writtenOn": "2019-08-19T13:03:19Z",
"side": 1,
"message": "I don\u0027t think critical is meant for this. It\u0027s not a bug, it\u0027s an upgrade impact. Can we use \u0027upgrade\u0027 instead?",
"range": {
"startLine": 1,
"startChar": 0,
"endLine": 1,
"endChar": 8
},
"revId": "4f1ba23f42a1192d48dd9e38f0f79779a0a0ce88",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}