From 52d9c5272363c0cc9c8930d02dfd71d138c12650 Mon Sep 17 00:00:00 2001 From: gecong1973 Date: Fri, 30 Sep 2016 16:30:29 +0800 Subject: [PATCH] Change assertTrue(isinstance()) by optimal assert Some of tests use different method of assertTrue(isinstance(A, B)) or assertEqual(type(A), B). The correct way is to use assertIsInstance(A, B) provided by testtools Change-Id: Ib8dec9d44ce66b1b7ff1486a234fae73d29f23ff --- sitemap/test/generator/test_pipelines.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sitemap/test/generator/test_pipelines.py b/sitemap/test/generator/test_pipelines.py index 1eec6b5d..30b71267 100644 --- a/sitemap/test/generator/test_pipelines.py +++ b/sitemap/test/generator/test_pipelines.py @@ -37,7 +37,7 @@ class TestIgnoreDuplicateUrls(unittest.TestCase): self.ignore_urls = pipelines.IgnoreDuplicateUrls() def test_set_is_set_at_init(self): - self.assertTrue(isinstance(self.ignore_urls.processed, set)) + self.assertIsInstance(self.ignore_urls.processed, set) def test_set_is_empty_at_init(self): self.assertEqual(len(self.ignore_urls.processed), 0) @@ -72,7 +72,7 @@ class TestExportSitemap(unittest.TestCase): self.spider = mock.MagicMock() def test_variables_set_at_init(self): - self.assertTrue(isinstance(self.export_sitemap.files, dict)) + self.assertIsInstance(self.export_sitemap.files, dict) self.assertTrue(self.export_sitemap.exporter is None) def test_spider_opened_calls_open(self):