openstack
/
openstack-doc-tools
Code Issues Proposed changes

trivial: Remove 'pass_through' 

This doesn't warrant it's own function and makes this a little more
difficult to read.

Change-Id: Ieff01bc97dc54b8ff68bff577803d41b921a1375
This commit is contained in:
Stephen Finucane 2017-03-09 15:18:11 +00:00
parent d962670652
commit b4492e34f9
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
autogenerate_config_docs/autohelp.py
View File

@ -400,18 +400,12 @@ def _use_categories(package_name):
return not os.path.isfile(package_name + '.disable')
def pass_through(line):
"""Whether to ignore the line."""
return (not line.strip() or
line.startswith('#'))
def _get_options_by_cat(package_name):
options_by_cat = {}
with open(package_name + '.flagmappings') as f:
for line in f:
if pass_through(line):
if not line.strip() or line.startswith('#'):
continue
opt, categories = line.split(' ', 1)
for category in categories.split():
@ -427,7 +421,7 @@ def _get_category_names(package_name):
try:
with open(headers_file) as f:
for line in f:
if pass_through(line):
if not line.strip() or line.startswith('#'):
continue
cat, nice_name = line.split(' ', 1)
category_names[cat] = nice_name.strip()