From e965de390ac2dc6660ce99bcbae3ac4f5dc3c3dd Mon Sep 17 00:00:00 2001
From: Andreas Jaeger <aj@suse.de>
Date: Mon, 19 May 2014 18:30:07 +0200
Subject: [PATCH] Add pylint target for testing

Add tox ini target for pylint and a pylintrc file. The file is copied
from cinder.

Change-Id: I3b94614ceca79ba5d352f94fe1d67df2a64d9ab9
---
 pylintrc              | 31 +++++++++++++++++++++++++++++++
 test-requirements.txt |  1 +
 tox.ini               |  4 +++-
 3 files changed, 35 insertions(+), 1 deletion(-)
 create mode 100644 pylintrc

diff --git a/pylintrc b/pylintrc
new file mode 100644
index 00000000..4ec63b1d
--- /dev/null
+++ b/pylintrc
@@ -0,0 +1,31 @@
+# The format of this file isn't really documented; just use --generate-rcfile
+
+[Messages Control]
+# C0111: Don't require docstrings on every method
+# W0511: TODOs in code comments are fine.
+# W0142: *args and **kwargs are fine.
+# W0622: Redefining id is fine.
+disable=C0111,W0511,W0142,W0622
+
+[Basic]
+# Variable names can be 1 to 31 characters long, with lowercase and underscores
+variable-rgx=[a-z_][a-z0-9_]{0,30}$
+
+# Argument names can be 2 to 31 characters long, with lowercase and underscores
+argument-rgx=[a-z_][a-z0-9_]{1,30}$
+
+# Method names should be at least 3 characters long
+# and be lowercased with underscores
+method-rgx=([a-z_][a-z0-9_]{2,50}|setUp|tearDown)$
+
+[Design]
+max-public-methods=100
+min-public-methods=0
+max-args=6
+
+[Variables]
+
+# List of additional names supposed to be defined in builtins. Remember that
+# you should avoid to define new builtins when possible.
+# _ is used by our localization
+additional-builtins=_
diff --git a/test-requirements.txt b/test-requirements.txt
index bac2be58..b5fc4d1a 100644
--- a/test-requirements.txt
+++ b/test-requirements.txt
@@ -1,3 +1,4 @@
 # Hacking already pins down pep8, pyflakes and flake8
 hacking>=0.8.0,<0.9
+pylint==0.25.2
 sphinx>=1.1.2,<1.2
diff --git a/tox.ini b/tox.ini
index 16578753..25728330 100644
--- a/tox.ini
+++ b/tox.ini
@@ -14,10 +14,12 @@ deps = -r{toxinidir}/requirements.txt
 [testenv:pep8]
 commands = flake8
 
+[testenv:pylint]
+commands = pylint os_doc_tools cleanup
+
 [testenv:venv]
 commands = {posargs}
 
-
 [flake8]
 # H803 skipped on purpose per list discussion.
 # E123, E125 skipped as they are invalid PEP-8.