a2a840b03b
Patch Set 1: Code-Review+2 (1 comment) Patch-set: 1 Reviewer: Gerrit User 28522 <28522@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=+2
99 lines
2.8 KiB
Plaintext
99 lines
2.8 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "bf51134e_ecaf5ae0",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 10,
|
|
"author": {
|
|
"id": 28522
|
|
},
|
|
"writtenOn": "2020-06-24T14:47:56Z",
|
|
"side": 1,
|
|
"message": "Are you sure this affirmation is valid [1]? \n\ninterop still use demjson in doc requirements [1].\n\n[1] https://github.com/openstack/interop/blob/master/doc/requirements.txt#L2",
|
|
"range": {
|
|
"startLine": 10,
|
|
"startChar": 8,
|
|
"endLine": 10,
|
|
"endChar": 54
|
|
},
|
|
"revId": "c2ecc30f16509fe8824839b42788ef5d5d2fe57f",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf51134e_8c433e13",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 10,
|
|
"author": {
|
|
"id": 11904
|
|
},
|
|
"writtenOn": "2020-06-24T14:51:10Z",
|
|
"side": 1,
|
|
"message": "Yes, as the full sentence states, it is not actually used in *this repo*. So it can be removed here.",
|
|
"parentUuid": "bf51134e_ecaf5ae0",
|
|
"range": {
|
|
"startLine": 10,
|
|
"startChar": 8,
|
|
"endLine": 10,
|
|
"endChar": 54
|
|
},
|
|
"revId": "c2ecc30f16509fe8824839b42788ef5d5d2fe57f",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf51134e_0c4f2e34",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 10,
|
|
"author": {
|
|
"id": 11904
|
|
},
|
|
"writtenOn": "2020-06-24T14:52:33Z",
|
|
"side": 1,
|
|
"message": "BTW, you really should use https://opendev.org, not GitHub. Some of those repos are stale, including interop that is no longer an openstack/ namespaced repo and not relevant for openstack/requirements.",
|
|
"parentUuid": "bf51134e_8c433e13",
|
|
"range": {
|
|
"startLine": 10,
|
|
"startChar": 8,
|
|
"endLine": 10,
|
|
"endChar": 54
|
|
},
|
|
"revId": "c2ecc30f16509fe8824839b42788ef5d5d2fe57f",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf51134e_0ca72ea9",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 10,
|
|
"author": {
|
|
"id": 28522
|
|
},
|
|
"writtenOn": "2020-06-24T15:02:02Z",
|
|
"side": 1,
|
|
"message": "Oh sorry I missed that point.",
|
|
"parentUuid": "bf51134e_0c4f2e34",
|
|
"range": {
|
|
"startLine": 10,
|
|
"startChar": 8,
|
|
"endLine": 10,
|
|
"endChar": 54
|
|
},
|
|
"revId": "c2ecc30f16509fe8824839b42788ef5d5d2fe57f",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |