openstack
/
openstack-health
Code Issues Proposed changes

Merge "Fix ratio to percent on failure rate graphs"

This commit is contained in:
Jenkins 2017-03-30 18:09:11 +00:00 committed by Gerrit Code Review
parent 94afaff0d6 c72ab70202
commit abbafad690
9 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/js/controllers/grouped-runs.js
View File

@ -110,7 +110,7 @@ function GroupedRunsController(
failRateEntries.push({
x: new Date(timedelta.datetime).getTime(),
y: failRate
y: failRate * 100
});
});

2
app/js/controllers/home.js
View File

@ -69,7 +69,7 @@ function HomeController(
angular.forEach(dateStats, function(stats) {
entries.passes.push(generateChartData(stats.date, stats.metrics.passes));
entries.failures.push(generateChartData(stats.date, stats.metrics.failures));
entries.failRate.push(generateChartData(stats.date, stats.metrics.failRate));
entries.failRate.push(generateChartData(stats.date, stats.metrics.failRate * 100));
});
entries.passes = entries.passes.sort(byDate);
entries.failures = entries.failures.sort(byDate);

2
app/js/controllers/job.js
View File

@ -131,7 +131,7 @@ function JobController(
failRate = totalFail / (totalFail + totalPass) || DEFAULT_FAIL_RATE;
failRateEntries.push({
x: new Date(date).getTime(),
y: failRate
y: failRate * 100
});
skipEntries.push({

2
app/views/grouped-runs.html
View File

@ -80,7 +80,7 @@
granular-format="%x %X"></chart-axis>
<chart-axis name="y" opposes="x" type="linear"
path=".y" align="left" orient="vertical"
domain="[0, 1]" draw="true"
domain="[0, 100]" draw="true"
granular-format=".3f"></chart-axis>
<chart-dataset name="rate"

2
app/views/home.html
View File

@ -83,7 +83,7 @@
granular-format="%x %X"></chart-axis>
<chart-axis name="y" type="linear" path=".y" opposes="x"
align="left" orient="vertical"
domain="[0, 1]" draw="true"
domain="[0, 100]" draw="true"
granular-format=".3f"></chart-axis>
<chart-dataset name="rate"

2
app/views/job.html
View File

@ -87,7 +87,7 @@
granular-format="%x %X"></chart-axis>
<chart-axis name="y" opposes="x" type="linear"
path=".y" align="left" orient="vertical"
domain="[0, 1]" draw="true"
domain="[0, 100]" draw="true"
granular-format=".3f"></chart-axis>
<chart-dataset name="rate"

2
test/unit/controllers/grouped_runs_spec.js
View File

@ -155,7 +155,7 @@ describe('GroupedRunsController', function() {
expect(groupedRunsController.failRates).toEqual([{
x: 1416355200000,
y: 0.023529411764705883
y: 2.3529411764705883
}]);
});
});

4
test/unit/controllers/home_spec.js
View File

@ -70,7 +70,7 @@ describe('HomeController', function() {
beforeEach(function() {
var date = new Date('2015-10-01T20:00:00.000Z');
timestamp = date.getTime();
var metrics = { passes: 3, failures: 4, failRate: 0.57 };
var metrics = { passes: 3, failures: 4, failRate: 56.99999999999999 };
var stats = [{ date: date, metrics: metrics }];
projectService.getStatsByDate = function() { return stats; };
homeController.loadData();
@ -82,7 +82,7 @@ describe('HomeController', function() {
});
it('should contain data for failure rate', function() {
expect(homeController.failRate).toEqual([{ x: 1443729600000, y: 0.57 }]);
expect(homeController.failRate).toEqual([{ x: 1443729600000, y: 5699.999999999999 }]);
});
});

2
test/unit/controllers/job_spec.js
View File

@ -147,7 +147,7 @@ describe('JobController', function() {
expect(jobController.failRates).toEqual([{
x: 1416358800000,
y: 0.018867924528301886
y: 1.8867924528301887
}]);
});