openstack
/
openstack-helm
Code Issues Proposed changes

Change default of ironic.conductor.api_url from internal to public 

Currently a pxe-client has to contact with ironic-api through
it's internal endpoint during lookup() period.

However, the pxe-client cannot access kube-dns by ifself,
so it needs additional dns server. (or Using NodePort)

With additional dns server, it will be safer for pxe-client
to contact with ironic-api through it's public endpoint(passing by ingress)
rather than internal endpoint directly becuase internal pod's IPs would be changed frequently.

Also, I refered to {Values.conf.ironic.glance.swift_endpoint_url}.
(swift is also accessed by the pxe-client and swift_url's default is public endpoint)

Change-Id: I0ad97f3ed608973d7e5a4a11d87595fe258a0db5
This commit is contained in:
jlego229-kim 2019-04-17 13:08:32 +09:00
parent f65c21de1e
commit 65bd9a7a04
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ironic/templates/configmap-etc.yaml
View File

@ -165,7 +165,7 @@ limitations under the License.
{{- end -}}
{{- if empty .Values.conf.ironic.conductor.api_url -}}
{{- $_ := tuple "baremetal" "internal" "api" . | include "helm-toolkit.endpoints.keystone_endpoint_uri_lookup"| set .Values.conf.ironic.conductor "api_url" -}}
{{- $_ := tuple "baremetal" "public" "api" . | include "helm-toolkit.endpoints.keystone_endpoint_uri_lookup"| set .Values.conf.ironic.conductor "api_url" -}}
{{- end -}}
{{- if empty .Values.conf.ironic.api.public_endpoint -}}