fix skyline db-sync image variable to match other chart style

The db-sync image variable of all charts is <chart>-db-sync and skyline
was different. This makes it behave the same as the others.

Change-Id: I9a8e75b002936a44382e68b7ec9c9b0b19c58b07

releasenotes/notes/skyline-db-sync-image-b56ba0a4cad85c9c.yaml

@@ -0,0 +1,6 @@
+---
+skyline:
+  - |
+    Fix db-sync container image tag variable to match the style of all other
+    charts to be prefixed with the project name.
+...

skyline/templates/job-db-sync.yaml

@@ -59,7 +59,7 @@ spec:
 {{ tuple . "db_sync" list | include "helm-toolkit.snippets.kubernetes_entrypoint_init_container" | indent 8 }}
       containers:
         - name: skyline-db-sync
-          image: {{ .Values.images.tags.db_sync | quote }}
+          image: {{ .Values.images.tags.skyline_db_sync | quote }}
           imagePullPolicy: {{ .Values.images.pull_policy | quote }}
 {{ tuple . .Values.pod.resources.jobs.db_sync | include "helm-toolkit.snippets.kubernetes_resources" | indent 10 }}
           env:

skyline/values.yaml

@@ -26,7 +26,7 @@ helm3_hook: true
 images:
   pull_policy: IfNotPresent
   tags:
-    db_sync: quay.io/airshipit/skyline:latest
+    skyline_db_sync: quay.io/airshipit/skyline:latest
     skyline: quay.io/airshipit/skyline:latest
     db_init: quay.io/airshipit/heat:2025.1-ubuntu_jammy
     dep_check: 'quay.io/airshipit/kubernetes-entrypoint:latest-ubuntu_jammy'