From 0756aa46aa4f4fa94344dde5d77512d4d5fef246 Mon Sep 17 00:00:00 2001
From: Saeed Padari <sam137115@gmail.com>
Date: Sat, 7 Feb 2026 20:51:23 +0330
Subject: [PATCH] manila: make manifest configurable for cephfs

Change-Id: I0f4de9776f5675f1c030a944aee6ac84ab980dd3
Signed-off-by: Saeed Padari <sam137115@gmail.com>
---
 manila/templates/bin/_ceph-keyring.sh.tpl       | 4 ++--
 manila/templates/deployment-share.yaml          | 7 +++++--
 manila/values.yaml                              | 5 +++++
 releasenotes/notes/manila-23590e37667d10a5.yaml | 8 ++++++++
 4 files changed, 20 insertions(+), 4 deletions(-)
 create mode 100644 releasenotes/notes/manila-23590e37667d10a5.yaml

diff --git a/manila/templates/bin/_ceph-keyring.sh.tpl b/manila/templates/bin/_ceph-keyring.sh.tpl
index 1267037e52..1713e03d28 100644
--- a/manila/templates/bin/_ceph-keyring.sh.tpl
+++ b/manila/templates/bin/_ceph-keyring.sh.tpl
@@ -17,7 +17,7 @@ limitations under the License.
 set -ex
 export HOME=/tmp
 
-cat > /etc/ceph/ceph.client.manila.keyring <<EOF
-[client.manila]
+cat > /etc/ceph/ceph.client.${CEPHFS_AUTH_ID}.keyring <<EOF
+[client.${CEPHFS_AUTH_ID}]
     key = $(cat /tmp/client-keyring)
 EOF
diff --git a/manila/templates/deployment-share.yaml b/manila/templates/deployment-share.yaml
index 1a3e546d8b..104714bcbe 100644
--- a/manila/templates/deployment-share.yaml
+++ b/manila/templates/deployment-share.yaml
@@ -84,6 +84,9 @@ spec:
         - name: ceph-keyring-placement
 {{ tuple $envAll "manila_share" | include "helm-toolkit.snippets.image" | indent 10 }}
 {{ dict "envAll" $envAll "application" "manila" "container" "ceph_keyring_placement" | include "helm-toolkit.snippets.kubernetes_container_security_context" | indent 10 }}
+          env:
+            - name: CEPHFS_AUTH_ID
+              value: {{ .Values.conf.manila.DEFAULT.cephfs_auth_id | quote }}
           command:
             - /tmp/ceph-keyring.sh
           volumeMounts:
@@ -206,11 +209,11 @@ spec:
           emptyDir: {}
         - name: ceph-etc
           configMap:
-            name: ceph-etc
+            name: {{ .Values.ceph_client.configmap }}
             defaultMode: 0444
         - name: ceph-keyring
           secret:
-            secretName: manila-keyring
+            secretName: {{ .Values.secrets.rbd | quote }}
 {{- end }}
 {{- dict "enabled" .Values.manifests.certificates "name" .Values.endpoints.oslo_db.auth.admin.secret.tls.internal | include "helm-toolkit.snippets.tls_volume" | indent 8 }}
 {{- dict "enabled" (or .Values.manifests.certificates .Values.tls.identity) "name" .Values.secrets.tls.share.api.internal | include "helm-toolkit.snippets.tls_volume" | indent 8 }}
diff --git a/manila/values.yaml b/manila/values.yaml
index dd8be4acea..43801730a1 100644
--- a/manila/values.yaml
+++ b/manila/values.yaml
@@ -314,6 +314,9 @@ bootstrap:
         container_format: bare
         private: false
 
+ceph_client:
+  configmap: ceph-etc
+
 dependencies:
   dynamic:
     common:
@@ -704,6 +707,7 @@ conf:
       api_paste_config: /etc/manila/api-paste.ini
       enabled_share_backends: generic
       enabled_share_protocols: NFS
+      cephfs_auth_id: manila
     keystone_authtoken:
       auth_type: password
       auth_version: v3
@@ -879,6 +883,7 @@ secrets:
   oslo_db:
     admin: manila-db-admin
     manila: manila-db-user
+  rbd: manila-keyring
   oslo_messaging:
     admin: manila-rabbitmq-admin
     manila: manila-rabbitmq-user
diff --git a/releasenotes/notes/manila-23590e37667d10a5.yaml b/releasenotes/notes/manila-23590e37667d10a5.yaml
new file mode 100644
index 0000000000..a52abd3e6a
--- /dev/null
+++ b/releasenotes/notes/manila-23590e37667d10a5.yaml
@@ -0,0 +1,8 @@
+---
+manila:
+  - |
+    This change enhances the flexibility of the Manila Chart by introducing
+    configurability for the CephFS backend. Previously, CephFS-related configuration values
+    were statically defined within the manifests, limiting deployment customization.
+    With this update, CephFS backend parameters can now be overridden via values.
+...