Update patch set 1

Patch Set 1: Code-Review-1

(1 comment)

Patch-set: 1
Reviewer: Gerrit User 4146 <4146@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 4146 2017-09-07 23:05:56 +00:00 committed by Gerrit Code Review
parent d6858da279
commit 59283bc931
1 changed files with 27 additions and 0 deletions

View File

@ -0,0 +1,27 @@
{
"comments": [
{
"key": {
"uuid": "7f287b81_73c14b54",
"filename": "roles/prepare-docs-for-afs/tasks/branch.yaml",
"patchSetId": 1
},
"lineNbr": 10,
"author": {
"id": 4146
},
"writtenOn": "2017-09-07T23:05:56Z",
"side": 1,
"message": "Since we are using basename below and not moving into dirname this isn\u0027t necessary. I think what we want here is to just recreate html/ since we\u0027ve mv\u0027d it away in line above.\n\nWe might consider publishing to zuul.branch though and stop worrying about dirname and basename. This would be more in line with how infra feature branches are being published. (I think this is my preference).",
"range": {
"startLine": 10,
"startChar": 4,
"endLine": 10,
"endChar": 55
},
"revId": "118b928e267414effe49482607c196335cd1da6c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}