openstack/openstack-zuul-jobs
Code Issues Proposed changes

Address breakage due to ansible-lint 6.5

Browse Source 
Pin ansible-lint<6.5 for now due to the
https://github.com/ansible/ansible-lint/issues/2320 regression which
ignores our skip tags.

Also add the zuul.d directory to the list of directories to avoid
linting, since those YAML files aren't Ansible files and it doesn't
seem to know not to try parsing them anyway.

While we're here, "fix" a task name not starting with an upper-case
letter, which for some reason ansible-lint now seems to think is
important. If we decide to continue using ansible-lint, it's
probably going to persist in complaining about that.

Change-Id: I46826210dfa4442af5c36d1439d1a1047ca0ba90
This commit is contained in:
Jeremy Stanley 2022-09-07 19:19:38 +00:00
parent 16edc5fa48
commit 6ced4627bd
3 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.ansible-lint
View File

@ -1,5 +1,6 @@
exclude_paths: exclude_paths:
- playbooks/legacy - playbooks/legacy
- zuul.d
parseable: true parseable: true
# [204] Lines < 160 # [204] Lines < 160
# [301] Commands should not change things if nothing needs doing # [301] Commands should not change things if nothing needs doing

2
roles/prepare-zanata-client/tasks/main.yaml
View File

@ -73,7 +73,7 @@
become: true become: true
# This is a preview module in Ansible 2.3. It may not work. # This is a preview module in Ansible 2.3. It may not work.
- name: import cert to java keystore - name: Import cert to java keystore
java_cert: java_cert:
cert_url: "{{ zanata_api_credentials.fqdn }}" cert_url: "{{ zanata_api_credentials.fqdn }}"
keystore_path: /etc/ssl/certs/java/cacerts keystore_path: /etc/ssl/certs/java/cacerts

3
test-requirements.txt
View File

@ -6,5 +6,6 @@ hacking>=4.0.0,<5.0.0 # Apache-2.0
# ansible-lint requires ansible>=2.9 # ansible-lint requires ansible>=2.9
ansible>=5,<6 ansible>=5,<6
ansible-lint>=6,<7 # pin until https://github.com/ansible/ansible-lint/issues/2320 is fixed
ansible-lint>=6,<6.5
bashate>=0.2 bashate>=0.2