From 78f01dc19e4e1efe99f5c6f7bafbbec700e1778d Mon Sep 17 00:00:00 2001
From: Ian Wienand <iwienand@redhat.com>
Date: Wed, 3 Aug 2022 14:57:31 +1000
Subject: [PATCH] grafana: explicitly validate graphs

Explicitly validate the graphs early to avoid doing anything if the
graphs won't load.

Change-Id: Ie9e858e4d8ce92e72de4358fecc40196f79b0229
---
 playbooks/grafana/main.yaml | 31 ++++++++++++++++++++-----------
 1 file changed, 20 insertions(+), 11 deletions(-)

diff --git a/playbooks/grafana/main.yaml b/playbooks/grafana/main.yaml
index fc5b93b6..912dab48 100644
--- a/playbooks/grafana/main.yaml
+++ b/playbooks/grafana/main.yaml
@@ -11,17 +11,6 @@
       include_role:
         name: use-buildset-registry
 
-    - name: install pip
-      include_role:
-        name: ensure-pip
-
-    - name: Install dependencies
-      package:
-        name:
-          - python3-docker
-        state: present
-      become: yes
-
     - name: Make environment vars
       set_fact:
         SECRETS_DIR: '{{ ansible_user_dir }}/grafana-secrets'
@@ -35,6 +24,26 @@
         # config file or something some other time.
         SCREENSHOT_HEIGHT: '5000'
 
+    # Initial sanity check
+    - name: Explicitly validate dashboards
+      shell:
+        executable: /bin/bash
+        cmd: |
+            docker run --rm -t -v {{ GRAFYAML_DIR }}:/grafana:ro \
+              --entrypoint /usr/local/bin/grafana-dashboard \
+                opendevorg/grafyaml --debug validate /grafana
+
+    - name: install pip
+      include_role:
+        name: ensure-pip
+
+    - name: Install dependencies
+      package:
+        name:
+          - python3-docker
+        state: present
+      become: yes
+
     - name: Setup test environment
       shell:
         executable: /bin/bash