openstack
/
openstack
Code Issues Proposed changes

Update git submodules 

* Update heat from branch 'master'
  - Merge "Unit tests: Fix wrong assert function name in port update"
  - Unit tests: Fix wrong assert function name in port update
    
    Due to a typo in an assert function name (assset_called_once_with()
    instead of assert_called_once_with()), we weren't actually checking the
    arguments passed to Neutron in UpdatePortTest. Fix the function name and
    modify the test so it actually works.
    
    Among the fixes required:
    
    - Actually return data from create_port
    - Call Resource.create() instead of handle_create(), to ensure that the
      resource is stored in the DB (and hence that it gets a name)
    - Mock show_port(), which is called from check_create_complete()
    - Handle later changes to the format of data passed (e.g. an empty
      allowed_address_pairs should be passed as an empty list instead of None)
    - Actually test the case where the port name is initially specified, and
      then removed on update
    - Fix the format of arguments to create_port and update_port
    
    This patch contains a workaround for a regression introduced by
    d37cc18b1b7a531edbcf9658600fc467fbe24e2d that causes a 'value_specs' key
    to be passed to the update_port call. This will be fixed in a subsequent
    patch.
    
    Change-Id: I37948721a0a653a18049aae6502fafb88030479c
    Co-Authored-By: zhufl <zhu.fanglei@zte.com.cn>
    Task: 34764
This commit is contained in:
Zuul 2019-07-11 08:54:04 +00:00 committed by Gerrit Code Review
parent 8f51b5aeff
commit 2b22cabcba
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
heat

@ -1 +1 @@
Subproject commit 5ee25d3c459561e5a628b5768d26c2c1ebcbc8ab
Subproject commit e42ef32b419aa175351dce22320d7ffeadd981dd