openstack
/
openstack
Code Issues Proposed changes

Update git submodules 

* Update nova from branch 'master'
  - Merge "Stop logging traceback when skipping quiesce"
  - Stop logging traceback when skipping quiesce
    
    During snapshot of a volume-backed instance, we attempt to quiesce the
    instance before doing the snapshot. If quiesce is not supported or the
    qemu guest agent is not enabled, we will skip the quiesce and move on
    to the snapshot.
    
    Because quiesce is a call to nova-compute over RPC, when the libvirt
    driver raises QemuGuestAgentNotEnabled, oslo.messaging will append the
    full traceback to the exception message [1] for the remote caller. So,
    a LOG.info(..., exp) log of the exception object will result in a log
    of the full traceback. Logging of the full traceback causes confusion
    for those debugging CI failures.
    
    We would rather not log the full traceback in this case where we are
    catching the exception and emitting an INFO message, so we should use
    exp.format_message() instead of oslo.messaging's __str__ override.
    
    [1] https://github.com/openstack/oslo.messaging/blob/40c25c2/oslo_messaging/_drivers/common.py#L212
    
    Related-Bug: #1824315
    
    Change-Id: Ibfedcb8814437c53081f5a2993ab84b25d73e557
This commit is contained in:
Zuul 2019-05-17 00:34:55 +00:00 committed by Gerrit Code Review
parent 491d332af1
commit 5950dd6d15
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
nova

@ -1 +1 @@
Subproject commit 344e17559ed441c308fa6d8eb7f858fc5e5b5d22
Subproject commit ed5b7c7fc311c2af8c8be09044bb2723141f6f0d