openstack
/
openstack
Code Issues Proposed changes

Updated openstack/openstack 

Project: openstack-infra/nose-html-output  71d12999b06908bbb019f69c89361bd44bec316c

Python 3 support

* Implicit relative import 'import version' to import htmloutput.version.
  Use explicit relative import instead 'from . import version'.
  Somehow 'from htmloutput import version' does not work for python2
  when I tested this with horizon nosetest.
* Python3 dict does not has_key(). Use 'not in' instead.
* Open a file for writing with 'wb' (binary mode).
  In Python 3, encode() converts unicode including regular string into
  bytes. In Python 2, encode() converts unicode string into string and
  string and bytes are handled equivalently. Thus, opening a file with
  binary mode works both for python2 and python3.
* Decoding from string to unicode is only needed for Python 2,
  so six.PY2 check is added to isinstance(x, str) if-clause.

Change-Id: Ied161e133ced1d672aba9d1a44b52034dfb676da
This commit is contained in:
Akihiro Motoki 2017-06-22 19:18:31 +09:00 committed by Gerrit Code Review
parent c711aadccc
commit 619c48488a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
nose-html-output

@ -1 +1 @@
Subproject commit 102b6d32c1ed87407788621e8e9d72f2099de54b
Subproject commit 71d12999b06908bbb019f69c89361bd44bec316c