openstack
/
openstack
Code Issues Proposed changes

Update git submodules 

* Update placement from branch 'master'
  - Avoid duplicate ProviderSummary in _merge_candidates
    
    In testing with the nested-perfload topology containing 7000
    providers, _merge_candidates had been returning 21000 ProviderSummary
    objects which were not trimmed until serialization processing in
    handlers/allocation_candidate.py. That situation has been present
    at least since when we added same_subtree [1] so is not simply
    because of the addition of rw_ctx.summaries_by_id [2].
    
    Teasing out fixing this exposed a lot of opportunities for
    shrinking the amount of data being inspected and processed.
    
    In no particular order the changes are:
    
    * Return set() from _alloc_candidates_single_provider and
      _alloc_candidates_multiple_providers instead of list. It doesn't need
      to be a list and the cast to list costs.
    
    * Because we have rw_ctx.summaries_by_id we don't need to return
      summaries from _get_by_one_request, they're in the rw_ctx.
    
    * The candidates provided to _merge_candidates is no longer a dict of
      tuples of allocatation requests and summaries (_all_ the summaries).
      It's just a dict of allocation requests.
    
    * At the end of _merge_candidates we need to winnow the contents of
      rw_ctx.summaries_by_id to only those that still matter.
    
    [1] I7fdeac24606359d37f1a7405d22c5797840e1a9e
    [2] I43ae1118421366336b4e96738c2981e07caebec8
    Change-Id: Ibccaed40f1eac9c244cf70654f6be1d72f7a6054
This commit is contained in:
Chris Dent 2019-08-09 12:32:49 +01:00 committed by Gerrit Code Review
parent 624e5419bf
commit 7df3904e70
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
placement

@ -1 +1 @@
Subproject commit 5dda479f5b80e7853e3aeec9a94df0ed4bf90248
Subproject commit aecd0f3497c5e4f1e73bf6c76a9add3db6270e27