openstack
/
openstack
Code Issues Proposed changes

Update git submodules 

* Update nova from branch 'master'
  - Merge "Hacking N362: Don't abbrev/alias privsep import"
  - Hacking N362: Don't abbrev/alias privsep import
    
    As noted in [1]:
    
    We always import privsep modules like this:
    
        import nova.privsep.libvirt
    
    Not like this:
    
        from nova.privsep import libvirt
    
    This is because it makes it obvious at the caller that a priviledged
    operation is occuring:
    
        nova.privsep.libvirt.destroy_root_filesystem()
    
    Not just:
    
        libvirt.destroy_root_filesystem()
    
    This is especially true when the imported module is called "libvirt",
    which is a very common term in the codebase and super hard to grep
    for specific uses of.
    
    This commit introduces hacking rule N362 to enforce the above.
    
    Change-Id: I9b6aefa015acbf28e49a9ff1713a8bb544586579
    Co-Authored-By: Eric Fried <openstack@fried.cc>
This commit is contained in:
Zuul 2019-04-05 18:39:17 +00:00 committed by Gerrit Code Review
parent ae958cdde2
commit 8d59a57931
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
nova

@ -1 +1 @@
Subproject commit fc8c957eea1bf2370a890cffeae39b159e79f4d4
Subproject commit 43ef38b53d2319d677faee5313082cade2da5d80