openstack
/
openstack
Code Issues Proposed changes

Update git submodules 

* Update nova from branch 'master'
  - Merge "Remove args(os=False) in monkey_patch"
  - Remove args(os=False) in monkey_patch
    
    The first patch introduced os=False is
    https://review.openstack.org/#/c/11556/
    
    But there is no explaination why nova should not monkey_patch `os`
    module. The args(os=False) make nova process has to wait while calling
     os.(['fdopen', 'read', 'write', 'wait', 'waitpid', 'open'])
    , which seems to be unnecessary.
    
    For nova-compute running on Windows(Hyper-v), `os` module should not be
    patched, because Windows pipes don't support non-blocking I/O. I add a
    comment to note that.
    
    [1] https://github.com/eventlet/eventlet/blob/v0.23.0/eventlet/green/os.py#L12
    
    Change-Id: I8b456676a04b9066cb2b570060c0d95cd4fe69f8
This commit is contained in:
Zuul 2019-01-18 18:19:45 +00:00 committed by Gerrit Code Review
parent a11a161ebf
commit 8ff0bed9a0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
nova

@ -1 +1 @@
Subproject commit 5ac6b2ef40543717d41721788144575a698fd0bd
Subproject commit 99ca7d60b41f63446f86ed9be86440a2b250f330