openstack/openstack
Code Issues Proposed changes

Update git submodules

Browse Source 
* Update python-ironicclient from branch 'master'
  - Fix AttributeError in negotiate_version
    
    Seen in kolla-ansible CI, if ironic inspector starts up before ironic
    API is properly up, we see the following error:
    
    The PXE filter DnsmasqFilter, state=initialized encountered an
    exception: StrictVersion instance has no attribute 'version'; resetting
    the filter: AttributeError: StrictVersion instance has no attribute
    'version'
    
    Example: http://paste.openstack.org/show/756342/
    
    The usual cause of this error is when StrictVersion is initialised with
    a version of None. This suggests to me that max_ver is None.
    
    This leads to an exception being raised that circumvents the client's
    retry mechanisms.
    
    In the particular case of kolla-ansible CI, Ironic API is behind a load
    balancer, and all backends are down resulting in a 503. The lack of a
    retry caused ironic inspector to fail on startup.
    
    This patch catches the case where we get a 4xx or 5xx return code when
    checking the version, and raises an error that works with the client's
    retry mechanisms.
    
    Change-Id: Ib62ca3ee4626084e5e9b90e93e4fa97938023457
    Story: 2006393
    Task: 36266
This commit is contained in:
Mark Goddard 2019-08-12 16:19:37 +01:00 committed by Gerrit Code Review
parent 1bd3b9e84a
commit c2045e63bb
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
python-ironicclient

@ -1 +1 @@
Subproject commit db180621dec0bc60649b6511722d506ad86d08bc
Subproject commit 0e9bf337f1f6aa41f67df2966dacf9e8e897b7da