openstack
/
openstack
Code Issues Proposed changes

Update git submodules 

* Update octavia from branch 'master'
  - Merge "Workaround peer name starting with hyphen"
  - Workaround peer name starting with hyphen
    
    The base64_sha_string method is used to set a base64-encoded peer name
    in HAProxy. There are cases where the peer name can start with
    an hypen which is troublesome when used in HAProxy CLI. Specifically,
    HAProxy fails to reload when local peer name starts with '-x' [1]. When
    this is the case, an amphora goes to provisioning status ERROR and later
    is scheduled for failover by the Octavia Health Manager service. A new
    amphora UUUID is assigned and base64 encoded, hopefully not starting
    with '-x' again. However, this is far from being ideal -- we incur in a
    dataplane disruption (single topology) or reduce HA capabilities
    (active-standby topology) for some time.
    
    Four possible options:
    
    a) add prefix to peer name
    b) change b64encode altchars
    c) quote peer name in haproxy CLI command
    d) substitute first character if hyphen
    
    Option a) and b) are not backward compatible with running amphorae. Peer
    names of existing amphorae that do not start with hypen but contain
    hyphen at any other position would get different peer names.
    
    Option c) would nonetheless still require an amphora image update to add
    quotes in the HAProxy init service file. Continuing to generate peer
    names with hyphens at begininng of the string is avoidable and
    recommended.
    
    Option d), while also requiring an amphora image update, it would get
    rid of hyphens in begining of the peer names. It is also backward
    compatible with all running amphorae, except for those starting with
    hyphen but are broken anyways.
    
    This patch takes option d). It substitutes hyphen with 'x' character.
    
    [1] https://github.com/haproxy/haproxy/issues/644
    
    Task: 39850
    Story: 2007714
    
    Change-Id: Ib0fc26877710dea423a5ebcf1f71077665404377
This commit is contained in:
Zuul 2020-05-31 14:55:45 +00:00 committed by Gerrit Code Review
parent d354b5539f
commit d57466e054
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
octavia

@ -1 +1 @@
Subproject commit 8a38c1a82b84b3312fe24e4efdbfc8d10622f2c7
Subproject commit 2c7c7747b74e866e5ab41139e2f3f01d9dce15a5