Update git submodules
* Update nova from branch 'master' - Merge "Fix mock specs set to strings" - Fix mock specs set to strings The behavior of Mock(spec=foo) or Mock(spec_set=foo) when foo is not a list is to interpret foo as a class or instance and derive the set of attributes you're allowed to get (spec) and/or set (spec_set) based on dir(foo) [1]. Thus if foo is a string, your mock will be set up to look like a string (with attributes like index, find, startswith...). So for example, if you see: Mock(spec='nova.objects.Instance') ...what was almost certainly intended was: Mock(spec=nova.objects.Instance) This commit fixes all such cases in the nova codebase, making those specs point to the actual classes as intended. A subsequent commit will introduce a hacking rule to ensure this mistake isn't repeated in the future. [1] https://docs.python.org/3/library/unittest.mock.html#the-mock-class Change-Id: I924edd474a798aa32bb8fb88ba6d84815a8bf93e
This commit is contained in:
parent
1af82b99ab
commit
d86c9c9593
2
nova
2
nova
|
@ -1 +1 @@
|
|||
Subproject commit 1588b2a1074d4bd83fa966fe3a0c518296bf6102
|
||||
Subproject commit 2e5d0eda841430fb697df04f4cbd020819e1bc87
|
Loading…
Reference in New Issue