openstack
/
openstack
Code Issues Proposed changes

Update git submodules 

* Update neutron from branch 'master'
  to 495fcd81ec120c6d494b7d4933dece6322d4eb83
  - Merge "Rely on worker count for HashRing caching"
  - Rely on worker count for HashRing caching
    
    The current code looks at a hash ring node's created_at/updated_at
    fields and tries to determine whether the node has been updated
    based on whether updated_at - created_at > 1 second (due to the
    method that initially fills them being different by microseconds).
    Unfortunately, due to the notify() method being called which calls
    the hash ring node's touch_node(), a node can be updated in under
    a second, meaning we will prevent caching for much longer than
    we intend.
    
    When using sqlite in-memory db, this continually re-creating the
    Hash Ring objects for every event that is processed is exposing an
    issue where rows that should be in the db just *aren't*.
    
    This patch instead limits the hash ring nodes to api workers and
    prevents caching only until the number of nodes == number of api
    workers on the host. The switch from spawning hash ring nodes
    where !is_maintenance to is_api_worker is primarily because it
    seems to be difficult to get a list of *all* workers from which to
    subtract the maintenance worker so that _wait_startup_before_caching
    can wait for that specific number of workers. In practice, this
    means that RpcWorker and ServiceWorker workers would not process
    HashRing events.
    
    A note on bug 1903008: While this change will greatly reduce the
    likelihood of this issue taking place, we still have some work to
    do in order to fully understand why it rubs the database backend
    in the wrong way. Thus, we will make this change 'related to'
    instead of closing the bug.
    
    Related-Bug: #1894117
    Related-Bug: #1903008
    Change-Id: Ia198d45f49bddda549a0e70a3374b8339f88887b
This commit is contained in:
Zuul 2021-01-05 01:15:51 +00:00 committed by Gerrit Code Review
parent c1a5acc2e1
commit e7d05b53c6
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
neutron

@ -1 +1 @@
Subproject commit 40cf711a22fd804860d521a4f00db07331fedfa2
Subproject commit 495fcd81ec120c6d494b7d4933dece6322d4eb83