Remove legacy bits from openstackclient-check-plugins

Change-Id: I5ef187f96d62fcf9813c98c568f549ecb8fc86ba

.zuul.yaml

@@ -1,7 +1,7 @@
 # from o-z-j/zuul.d/zuul-legacy-jobs.yaml
 - job:
     name: openstackclient-check-plugins
-    parent: legacy-base
+    parent: unittests
     run: playbooks/openstackclient-check-plugins/run
     timeout: 1800
     voting: false

playbooks/openstackclient-check-plugins/run.yaml

@@ -1,62 +1,11 @@
 - hosts: all
-  name: Autoconverted job legacy-check-osc-plugins from old job check-osc-plugins
+  name: Run osc plugin check script
   tasks:
 
-    - name: Ensure legacy workspace directory
-      file:
-        path: '{{ ansible_user_dir }}/workspace'
-        state: directory
-
-    - shell:
-        cmd: |
-          set -e
-          set -x
-          CLONEMAP=`mktemp`
-          function cleanup {
-              # In cases where zuul-cloner is aborted during a git
-              # clone operation, git will remove the git work tree in
-              # its cleanup. The work tree in these jobs is the
-              # workspace directory, which means that subsequent
-              # jenkins post-build actions can not run because the
-              # workspace has been removed.
-              # To reduce the likelihood of this having an impact,
-              # recreate the workspace directory if needed
-              mkdir -p $WORKSPACE
-              rm -f $CLONEMAP
-          }
-          trap cleanup EXIT
-          cat > $CLONEMAP << EOF
-          clonemap:
-            - name: $ZUUL_PROJECT
-              dest: .
-          EOF
-          /usr/zuul-env/bin/zuul-cloner -m $CLONEMAP --cache-dir /opt/git \
-              git://git.openstack.org $ZUUL_PROJECT
-        executable: /bin/bash
-        chdir: '{{ ansible_user_dir }}/workspace'
-      environment: '{{ zuul | zuul_legacy_vars }}'
-
-    - shell:
-        cmd: /usr/local/jenkins/slave_scripts/install-distro-packages.sh
-        chdir: '{{ ansible_user_dir }}/workspace'
-      environment: '{{ zuul | zuul_legacy_vars }}'
-
-    - shell:
-        cmd: |
-          set -x
-          sudo rm -f /etc/sudoers.d/zuul
-          # Prove that general sudo access is actually revoked
-          ! sudo -n true
-        executable: /bin/bash
-        chdir: '{{ ansible_user_dir }}/workspace'
-      environment: '{{ zuul | zuul_legacy_vars }}'
-
     - shell:
         cmd: |
           pwd
           set
           echo {{ ansible_user_dir }}
           ls -l
-          src/{{ zuul.project.canonical_name }}/openstackclient/tests/plugins/check-osc-plugins.sh
-        chdir: '{{ ansible_user_dir }}/workspace'
-      environment: '{{ zuul | zuul_legacy_vars }}'
+          src/git.openstack.org/openstack/openstackclient/tests/plugins/check-osc-plugins.sh