From b7bd239e81752fbc9319fb326960613c87e16719 Mon Sep 17 00:00:00 2001
From: Akihiro Motoki <amotoki@gmail.com>
Date: Mon, 8 Mar 2021 21:07:16 +0900
Subject: [PATCH] osc-check-plugins job: Ensure OSC plugins from git

openstackclient-check-plugins did not install OSC plugins
from git even when they are specified in required-projects.
This happened "item.short_name" is not evaluated.

Change-Id: I069e63005ad2cd24f134fee475fa246bf324a7e2
---
 playbooks/openstackclient-check-plugins/run.yaml | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/playbooks/openstackclient-check-plugins/run.yaml b/playbooks/openstackclient-check-plugins/run.yaml
index 892ed3b..8d0fdb6 100644
--- a/playbooks/openstackclient-check-plugins/run.yaml
+++ b/playbooks/openstackclient-check-plugins/run.yaml
@@ -26,10 +26,11 @@
     - name: Install repos that are in requirements.txt
       shell:
         cmd: |
-           grep item.short_name requirements.txt
-           if [ $? -eq 0 ] ; then
-             osc_plugins/bin/pip install -c upper-constraints.txt -e {{ ansible_user_dir }}/{{ item.src_dir }}
-           fi
+          echo "------------------------------------------------------------"
+          grep {{ item.short_name }} requirements.txt
+          if [ $? -eq 0 ] ; then
+            osc_plugins/bin/pip install -c upper-constraints.txt -e {{ ansible_user_dir }}/{{ item.src_dir }}
+          fi
       args:
         chdir: /home/zuul/src/opendev.org/openstack/openstackclient
       with_items: "{{ zuul.projects.values() | list }}"