From b86edc3683ea73e0ecbe3d7d2c1495a1842d836c Mon Sep 17 00:00:00 2001 From: tischrei Date: Tue, 8 Dec 2020 11:46:50 +0000 Subject: [PATCH] Add id query parameter to sg rules id paramter is needed for filter functionality in Ansible modules. See PR https://review.opendev.org/c/openstack/ansible-collections-openstack/+/765580 Change-Id: If08fa34672ff32dda139b0b50cc7c4af89107846 --- openstack/network/v2/security_group_rule.py | 2 +- openstack/tests/unit/network/v2/test_security_group_rule.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/openstack/network/v2/security_group_rule.py b/openstack/network/v2/security_group_rule.py index 398366e5c..35092ec9f 100644 --- a/openstack/network/v2/security_group_rule.py +++ b/openstack/network/v2/security_group_rule.py @@ -27,7 +27,7 @@ class SecurityGroupRule(_base.NetworkResource, resource.TagMixin): allow_list = True _query_mapping = resource.QueryParameters( - 'description', 'direction', 'protocol', + 'description', 'direction', 'id', 'protocol', 'remote_group_id', 'security_group_id', 'port_range_max', 'port_range_min', 'remote_ip_prefix', 'revision_number', diff --git a/openstack/tests/unit/network/v2/test_security_group_rule.py b/openstack/tests/unit/network/v2/test_security_group_rule.py index 981c81227..bb3450217 100644 --- a/openstack/tests/unit/network/v2/test_security_group_rule.py +++ b/openstack/tests/unit/network/v2/test_security_group_rule.py @@ -50,6 +50,7 @@ class TestSecurityGroupRule(base.TestCase): self.assertDictEqual({'any_tags': 'tags-any', 'description': 'description', 'direction': 'direction', + 'id': 'id', 'ether_type': 'ethertype', 'limit': 'limit', 'marker': 'marker',