openstack
/
openstacksdk
Code Issues Proposed changes

Workaround older octavia version discovery 

Older octavia didn't have a working version discovery document,
and python-octaviaclient just appends v2.0 to the endpoint like
neutronclient did. Rather than getting ourselves worked up about
it, just apply the same hack that we apply for neutronclient.

Change-Id: Ib433eba2e4946d3db7fd9352f4c8f170193da72d
This commit is contained in:
Monty Taylor 2019-05-08 13:16:42 +00:00
parent a8e2737127
commit 364b17e2f0
1 changed files with 20 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
openstack/config/cloud_region.py
View File

@ -477,6 +477,21 @@ class CloudRegion(object):
self.get_interface(service_type), {})
return interface_versions.get(service_type, [])
def _get_hardcoded_endpoint(self, service_type, constructor):
adapter = constructor(
session=self.get_session(),
service_type=self.get_service_type(service_type),
service_name=self.get_service_name(service_type),
interface=self.get_interface(service_type),
region_name=self.region_name,
)
endpoint = adapter.get_endpoint()
if not endpoint.rstrip().rsplit('/')[-1] == 'v2.0':
if not endpoint.endswith('/'):
endpoint += '/'
endpoint = urllib.parse.urljoin(endpoint, 'v2.0')
return endpoint
def get_session_client(
self, service_type, version=None,
constructor=proxy.Proxy,
@ -511,27 +526,17 @@ class CloudRegion(object):
kwargs.pop('min_version', None) or version_request.min_api_version)
max_api_version = (
kwargs.pop('max_version', None) or version_request.max_api_version)
# Older neutron has inaccessible discovery document. Nobody noticed
# because neutronclient hard-codes an append of v2.0. YAY!
if service_type == 'network':
# Also, older octavia has a similar issue.
if service_type in ('network', 'load-balancer'):
version = None
min_api_version = None
max_api_version = None
if endpoint_override is None:
network_adapter = constructor(
session=self.get_session(),
service_type=self.get_service_type(service_type),
service_name=self.get_service_name(service_type),
interface=self.get_interface(service_type),
region_name=self.region_name,
)
network_endpoint = network_adapter.get_endpoint()
if not network_endpoint.rstrip().rsplit('/')[-1] == 'v2.0':
if not network_endpoint.endswith('/'):
network_endpoint += '/'
network_endpoint = urllib.parse.urljoin(
network_endpoint, 'v2.0')
endpoint_override = network_endpoint
endpoint_override = self._get_hardcoded_endpoint(
service_type, constructor)
client = constructor(
session=self.get_session(),