openstack
/
openstacksdk
Code Issues Proposed changes

Merge "Avoid default mutable values in arguments"

This commit is contained in:
Zuul 2017-11-16 15:14:30 +00:00 committed by Gerrit Code Review
parent 6abc651cfb 3070a6e1cc
commit 49b78b2846
3 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
openstack/clustering/v1/_proxy.py
View File

@ -1089,7 +1089,7 @@ class Proxy(proxy2.BaseProxy):
"""
return self._list(_event.Event, paginated=True, **query)
def wait_for_status(self, resource, status, failures=[], interval=2,
def wait_for_status(self, resource, status, failures=None, interval=2,
wait=120):
"""Wait for a resource to be in a particular status.
@ -1111,6 +1111,7 @@ class Proxy(proxy2.BaseProxy):
:raises: :class:`~AttributeError` if the resource does not have a
``status`` attribute.
"""
failures = [] if failures is None else failures
return resource2.wait_for_status(self, resource, status,
failures, interval, wait)

3
openstack/proxy.py
View File

@ -246,7 +246,7 @@ class BaseProxy(_adapter.OpenStackSDKAdapter):
return res.head(self)
def wait_for_status(self, value, status, failures=[], interval=2,
def wait_for_status(self, value, status, failures=None, interval=2,
wait=120):
"""Wait for a resource to be in a particular status.
@ -267,6 +267,7 @@ class BaseProxy(_adapter.OpenStackSDKAdapter):
:raises: :class:`~AttributeError` if the resource does not have a
status attribute
"""
failures = [] if failures is None else failures
return resource.wait_for_status(self, value, status,
failures, interval, wait)

3
openstack/proxy2.py
View File

@ -264,7 +264,7 @@ class BaseProxy(_adapter.OpenStackSDKAdapter):
"service-specific subclasses should expose "
"this as needed. See resource2.wait_for_status "
"for this behavior"))
def wait_for_status(self, value, status, failures=[], interval=2,
def wait_for_status(self, value, status, failures=None, interval=2,
wait=120):
"""Wait for a resource to be in a particular status.
@ -285,6 +285,7 @@ class BaseProxy(_adapter.OpenStackSDKAdapter):
:raises: :class:`~AttributeError` if the resource does not have a
status attribute
"""
failures = [] if failures is None else failures
return resource2.wait_for_status(self, value, status,
failures, interval, wait)