openstack/openstacksdk
Code Issues Proposed changes

baremetal-introspection: fix passing a Node to start_introspection

Browse Source 
Currently only a string ID is supported despite what the docstring claims.

Change-Id: I59f8f85a31395c8a096cd507421cebb36d18198d
This commit is contained in:
Dmitry Tantsur
2019-09-10 13:55:36 +02:00
parent ca780d3bb8
commit 4a6b5beb77
3 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
openstack/baremetal_introspection/v1/_proxy.py
View File

@@ -11,6 +11,7 @@
# under the License. # under the License.
from openstack import _log from openstack import _log
from openstack.baremetal.v1 import node as _node
from openstack.baremetal_introspection.v1 import introspection as _introspect from openstack.baremetal_introspection.v1 import introspection as _introspect
from openstack import exceptions from openstack import exceptions
from openstack import proxy from openstack import proxy
@@ -63,7 +64,8 @@ class Proxy(proxy.Proxy):
:returns: :class:`~.introspection.Introspection` instance. :returns: :class:`~.introspection.Introspection` instance.
""" """
return self._create(_introspect.Introspection, id=node) node = self._get_resource(_node.Node, node)
return self._create(_introspect.Introspection, id=node.id)
def get_introspection(self, introspection): def get_introspection(self, introspection):
"""Get a specific introspection. """Get a specific introspection.

7
openstack/tests/unit/baremetal_introspection/v1/test_proxy.py
View File

@@ -14,6 +14,7 @@ import mock
from keystoneauth1 import adapter from keystoneauth1 import adapter
from openstack.baremetal.v1 import node as _node
from openstack.baremetal_introspection.v1 import _proxy from openstack.baremetal_introspection.v1 import _proxy
from openstack.baremetal_introspection.v1 import introspection from openstack.baremetal_introspection.v1 import introspection
from openstack import exceptions from openstack import exceptions
@@ -33,6 +34,12 @@ class TestBaremetalIntrospectionProxy(test_proxy_base.TestProxyBase):
method_kwargs={'node': 'abcd'}, method_kwargs={'node': 'abcd'},
expected_kwargs={'id': 'abcd'}) expected_kwargs={'id': 'abcd'})
def test_create_introspection_with_node(self):
self.verify_create(self.proxy.start_introspection,
introspection.Introspection,
method_kwargs={'node': _node.Node(id='abcd')},
expected_kwargs={'id': 'abcd'})
def test_get_introspection(self): def test_get_introspection(self):
self.verify_get(self.proxy.get_introspection, self.verify_get(self.proxy.get_introspection,
introspection.Introspection) introspection.Introspection)

4
releasenotes/notes/introspection-node-6a3b7d55839ef82c.yaml Normal file
View File

@@ -0,0 +1,4 @@
---
fixes:
- |
Fixes using a full `Node` object as an argument to `start_introspection`.