From 568921ce5b50275061c5dd0ba7180842f3c157a7 Mon Sep 17 00:00:00 2001 From: Stephen Finucane Date: Thu, 15 Feb 2024 14:19:10 +0000 Subject: [PATCH] tox: Correct functional test factors We are running functional tests in zuul without a 'pyNN' factor (e.g. 'tox -e functional'). For this to work, we need to allow an empty factor, i.e. we want: [testenv:functional{,-py310}] rather than: [testenv:functional{-py310}] (note the missing comma) Unfortunately we missed this as tox 4 has a currently unaddressed regression [1] that results in it running the base testenv in the case there is only a partial factor match. That needs to be fixed for avoid this biting us again the future, but we can at least fix it for now. [1] https://github.com/tox-dev/tox/issues/3219 Change-Id: Ib9f65a4523222f1224d51534c5061f90501b59d3 Signed-off-by: Stephen Finucane --- tox.ini | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tox.ini b/tox.ini index bdc0a3737..693535a1c 100644 --- a/tox.ini +++ b/tox.ini @@ -23,7 +23,7 @@ commands = stestr run {posargs} stestr slowest -[testenv:functional{-py37,-py38,-py39}] +[testenv:functional{,-py37,-py38,-py39,-py310,-py311,-py312}] description = Run functional tests. # Some jobs (especially heat) takes longer, therefore increase default timeout