openstack/openstacksdk
Code Issues Proposed changes

Merge "Followup to I0e5ac1288c0d0423fa3a7a4e63173675b78aae79"

Browse Source
This commit is contained in:
Zuul 2024-09-17 14:49:10 +00:00 committed by Gerrit Code Review
commit 6dcde9d82a
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
openstack/key_manager/v1/secret.py
View File

@ -113,6 +113,13 @@ class Secret(resource.Resource):
headers={"Accept": content_type}, headers={"Accept": content_type},
skip_cache=skip_cache, skip_cache=skip_cache,
) )
# NOTE(pas-ha): do not return payload.text here,
# as it will be decoded to whatever requests and chardet detected,
# and if they are wrong, there'd be no way of getting original
# bytes back and try to re-decode.
# At least this way, the encoding is always the same,
# so SDK user can always get original bytes back and fix things.
# Besides, this is exactly what python-barbicanclient does.
if content_type == "text/plain": if content_type == "text/plain":
response["payload"] = payload.content.decode("UTF-8") response["payload"] = payload.content.decode("UTF-8")
else: else: