openstack/openstacksdk
Code Issues Proposed changes

find_security_group_rule does not find by name

Browse Source 
The find_security_group_rule proxy documents that a security
group rule can be found by name or ID.  However, security
group rules do not have names.  This patch set corrects the
documentation.

Change-Id: I06f324ace50c2ce377263727e6a6bed6e4128c93
Closes-Bug: #1464362
This commit is contained in:
Richard Theis 2015-11-24 16:05:56 -06:00
parent 5ead75e0f7
commit 7f02817c04
1 changed files with 3 additions and 3 deletions

6
openstack/network/v2/_proxy.py

@ -1150,10 +1150,10 @@ class Proxy(proxy.BaseProxy):
self._delete(security_group_rule.SecurityGroupRule,
value, ignore_missing=ignore_missing)
def find_security_group_rule(self, name_or_id, ignore_missing=True):
def find_security_group_rule(self, value, ignore_missing=True):
"""Find a single security group rule
:param name_or_id: The name or ID of a security group rule.
:param value: The ID of a security group rule.
:param bool ignore_missing: When set to ``False``
:class:`~openstack.exceptions.ResourceNotFound` will be
raised when the resource does not exist.
@ -1163,7 +1163,7 @@ class Proxy(proxy.BaseProxy):
SecurityGroupRule` or None
"""
return self._find(security_group_rule.SecurityGroupRule,
name_or_id, ignore_missing=ignore_missing)
value, ignore_missing=ignore_missing)
def get_security_group_rule(self, value):
"""Get a single security group rule