openstack/openstacksdk
Code Issues Proposed changes

Bump default timeout values

Browse Source 
We're getting a fair number of timeouts sporadically. The VMs seem to
just be running a bit slower... give ourselves a bit more headroom.

Change-Id: I74ffd304d581e7449b8f850b2412ef1dce6effb1
This commit is contained in:
Monty Taylor
2018-05-10 11:58:13 -05:00
parent daf889a315
commit 8447e82b29
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
openstack/tests/base.py
View File

@@ -37,13 +37,13 @@ class TestCase(base.BaseTestCase):
def setUp(self): def setUp(self):
"""Run before each test method to initialize test environment.""" """Run before each test method to initialize test environment."""
# No openstacksdk unit tests should EVER run longer than a second. # No openstacksdk unit tests should EVER run longer than a second.
# Set this to 3 by default just to give us some fudge. # Set this to 5 by default just to give us some fudge.
# Do this before super setUp so that we intercept the default value # Do this before super setUp so that we intercept the default value
# in oslotest. TODO(mordred) Make the default timeout configurable # in oslotest. TODO(mordred) Make the default timeout configurable
# in oslotest. # in oslotest.
self.useFixture( self.useFixture(
fixtures.EnvironmentVariable( fixtures.EnvironmentVariable(
'OS_TEST_TIMEOUT', os.environ.get('OS_TEST_TIMEOUT', '3'))) 'OS_TEST_TIMEOUT', os.environ.get('OS_TEST_TIMEOUT', '5')))
super(TestCase, self).setUp() super(TestCase, self).setUp()

2
openstack/tests/functional/cloud/test_compute.py
View File

@@ -30,7 +30,7 @@ from openstack import utils
class TestCompute(base.BaseFunctionalTestCase): class TestCompute(base.BaseFunctionalTestCase):
def setUp(self): def setUp(self):
# OS_TEST_TIMEOUT is 60 sec by default # OS_TEST_TIMEOUT is 90 sec by default
# but on a bad day, test_attach_detach_volume can take more time. # but on a bad day, test_attach_detach_volume can take more time.
self.TIMEOUT_SCALING_FACTOR = 1.5 self.TIMEOUT_SCALING_FACTOR = 1.5

2
tox.ini
View File

@@ -30,7 +30,7 @@ commands = stestr --test-path ./openstack/tests/examples run {posargs}
basepython = {env:OPENSTACKSDK_TOX_PYTHON:python2} basepython = {env:OPENSTACKSDK_TOX_PYTHON:python2}
setenv = setenv =
{[testenv]setenv} {[testenv]setenv}
OS_TEST_TIMEOUT=60 OS_TEST_TIMEOUT=90
commands = stestr --test-path ./openstack/tests/functional run --serial {posargs} commands = stestr --test-path ./openstack/tests/functional run --serial {posargs}
stestr slowest stestr slowest