openstack/openstacksdk
Code Issues Proposed changes

Add parameters to the list for filtering

Browse Source 
Allow lists to be filtered by the server.  For example:

report_filter = {'router:external': True}
data = network.Network.list(client.session, **report_filter)

Returns only external networks.

Change-Id: Ia90421e18fe94036fe3a2b89fc448ff5e9169674
This commit is contained in:
Terry Howe 2014-07-03 11:51:56 -06:00
parent c02cdb7e22
commit 924cc302ab
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
openstack/resource.py
View File

@ -303,7 +303,7 @@ class Resource(collections.MutableMapping):
self.delete_by_id(session, self.id)
@classmethod
def list(cls, session, limit=None, marker=None):
def list(cls, session, limit=None, marker=None, **params):
# NOTE(jamielennox): Is it possible we can return a generator from here
# and allow us to keep paging rather than limit and marker?
if not cls.allow_list:
@ -320,7 +320,7 @@ class Resource(collections.MutableMapping):
if filters:
url = '%s?%s' % (url, url_parse.urlencode(filters))
resp = session.get(url, service=cls.service).body
resp = session.get(url, service=cls.service, params=params).body
if cls.resources_key:
resp = resp[cls.resources_key]