openstack/openstacksdk
Code Issues Proposed changes

fix: improperly encoded object names

Browse Source 
Static Large Object (SLO) manifests do not allow urlencoded
object names.

Related change: Ifbcde7f1c59bee16b4c133c3ff4ff69858c774ce

Change-Id: I5a7a7c50f67d3fbda7e2df2492ccaa8e3c9f0fee
This commit is contained in:
Daniel Speichert 2022-03-21 12:46:37 -04:00
parent fcd5be224c
commit bdccc6b798
1 changed files with 7 additions and 2 deletions

9
openstack/object_store/v1/_proxy.py

@ -591,7 +591,10 @@ class Proxy(proxy.Proxy):
# TODO(mordred) Collect etags from results to add to this manifest
# dict. Then sort the list of dicts by path.
manifest.append(dict(
path='/{name}'.format(name=name),
# While Object Storage usually expects the name to be
# urlencoded in most requests, the SLO manifest requires
# plain object names instead.
path='/{name}'.format(name=parse.unquote(name)),
size_bytes=segment.length))
# Try once and collect failed results to retry
@ -731,7 +734,9 @@ class Proxy(proxy.Proxy):
continue
name = self._object_name_from_url(result.url)
for entry in manifest:
if entry['path'] == '/{name}'.format(name=name):
if entry['path'] == '/{name}'.format(
name=parse.unquote(name)
):
entry['etag'] = result.headers['Etag']
def get_info(self):