openstack/openstacksdk
Code Issues Proposed changes

Fix latest flake8 issues

Browse Source 
The latest flake8 checks strings for escape chars, and also has a new
and better rule about line breaks before binary operators - which is
what knuth says should happen.

The escape char check was catching some asterisks in docstrings that
weren't actually providing much, since we already list type as "kwargs".
Just remove them.

Install latest flake8 so we can gate on this.

Change-Id: I89088adcc6f4ff5a894df5e677ae9b28a58edd9a
This commit is contained in:
Monty Taylor
2018-10-29 14:21:42 -05:00
parent a30cc754f2
commit d42811c405
31 changed files with 143 additions and 131 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
openstack/cloud/meta.py
View File

@@ -404,8 +404,9 @@ def _get_supplemental_addresses(cloud, server):
try:
# Don't bother doing this before the server is active, it's a waste
# of an API call while polling for a server to come up
if (cloud.has_service('network') and cloud._has_floating_ips() and
server['status'] == 'ACTIVE'):
if (cloud.has_service('network')
and cloud._has_floating_ips()
and server['status'] == 'ACTIVE'):
for port in cloud.search_ports(
filters=dict(device_id=server['id'])):
# This SHOULD return one and only one FIP - but doing it as a