openstack/openstacksdk
Code Issues Proposed changes

Fix misuse of assertTrue

Browse Source 
Fix misuse of assertTrue by replacing with assertEqual.

Signed-off-by: Takashi Natsume <takanattie@gmail.com>
Change-Id: If6dfc295e062da660d408af50a06cac69bf03da9
This commit is contained in:
Takashi Natsume 2021-12-19 14:56:55 +09:00
parent 26c9bc22e3
commit d709887645
2 changed files with 5 additions and 5 deletions
openstack/tests/unit
image/v2
test_proxy.py
test_resource.py

4
openstack/tests/unit/image/v2/test_proxy.py

@ -429,7 +429,7 @@ class TestImageProxy(test_proxy_base.TestProxyBase):
result = self.proxy.wait_for_task(
res, status, "failure", 0.01, 0.1)
self.assertTrue(result, res)
self.assertEqual(res, result)
def test_wait_for_task_immediate_status_case(self):
status = "SUCcess"
@ -438,7 +438,7 @@ class TestImageProxy(test_proxy_base.TestProxyBase):
result = self.proxy.wait_for_task(
res, status, "failure", 0.01, 0.1)
self.assertTrue(result, res)
self.assertEqual(res, result)
def test_wait_for_task_error_396(self):
# Ensure we create a new task when we get 396 error

6
openstack/tests/unit/test_resource.py

@ -2925,7 +2925,7 @@ class TestWaitForStatus(base.TestCase):
result = resource.wait_for_status(
self.cloud.compute, res, status, "failures", "interval", "wait")
self.assertTrue(result, res)
self.assertEqual(res, result)
def test_immediate_status_case(self):
status = "LOLing"
@ -2935,7 +2935,7 @@ class TestWaitForStatus(base.TestCase):
result = resource.wait_for_status(
self.cloud.compute, res, 'lOling', "failures", "interval", "wait")
self.assertTrue(result, res)
self.assertEqual(res, result)
def test_immediate_status_different_attribute(self):
status = "loling"
@ -2946,7 +2946,7 @@ class TestWaitForStatus(base.TestCase):
self.cloud.compute, res, status, "failures", "interval", "wait",
attribute='mood')
self.assertTrue(result, res)
self.assertEqual(res, result)
def _resources_from_statuses(self, *statuses, **kwargs):
attribute = kwargs.pop('attribute', 'status')