openstack
/
openstacksdk
Code Issues Proposed changes

Fix bm tests: sort lists being compared 

These tests were randomly failing because they are not being
sorted before being compared.

Change-Id: Ib4e8820494deee0c11fe785abf420196989f389b
This commit is contained in:
David Shrewsbury 2019-08-05 11:54:18 -04:00
parent 8feaadfdd5
commit e81fe82fce
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
openstack/tests/functional/baremetal/test_baremetal_node.py
View File

@ -323,9 +323,11 @@ class TestTraits(base.BaseBaremetalTest):
self.assertEqual(['CUSTOM_FAKE'], node.traits)
self.conn.baremetal.add_node_trait(self.node, 'CUSTOM_REAL')
self.assertEqual(['CUSTOM_FAKE', 'CUSTOM_REAL'], self.node.traits)
self.assertEqual(sorted(['CUSTOM_FAKE', 'CUSTOM_REAL']),
sorted(self.node.traits))
node = self.conn.baremetal.get_node(self.node)
self.assertEqual(['CUSTOM_FAKE', 'CUSTOM_REAL'], node.traits)
self.assertEqual(sorted(['CUSTOM_FAKE', 'CUSTOM_REAL']),
sorted(node.traits))
self.conn.baremetal.remove_node_trait(node, 'CUSTOM_FAKE',
ignore_missing=False)
@ -341,9 +343,9 @@ class TestTraits(base.BaseBaremetalTest):
traits2 = ['CUSTOM_FOOBAR']
self.conn.baremetal.set_node_traits(self.node, traits1)
self.assertEqual(['CUSTOM_FAKE', 'CUSTOM_REAL'], self.node.traits)
self.assertEqual(sorted(traits1), sorted(self.node.traits))
node = self.conn.baremetal.get_node(self.node)
self.assertEqual(['CUSTOM_FAKE', 'CUSTOM_REAL'], node.traits)
self.assertEqual(sorted(traits1), sorted(node.traits))
self.conn.baremetal.set_node_traits(self.node, traits2)
self.assertEqual(['CUSTOM_FOOBAR'], self.node.traits)