openstack/openstacksdk
Code Issues Proposed changes

Create a method to handle the set_* method logic

Browse Source 
This allows us to deduplicate most of the logic in those methods and by
abstracting it into a single method.

Change-Id: I56b6e1759aa4f6a3d8ceba85ca848935346ca6c0
This commit is contained in:
Ian Cordasco 2014-10-27 16:06:43 -05:00
parent f4bfcdf40f
commit eefe158095
1 changed files with 16 additions and 24 deletions

40
openstack/user_preference.py

@ -105,18 +105,24 @@ class UserPreference(object):
(service, self.service_names))
raise exceptions.SDKException(msg)
def _setattr_on_service(self, service, attr, name, is_callable=False):
if service == self.ALL:
services = self.service_names
else:
services = [service]
for serv in services:
if is_callable:
getattr(self._get_service(serv), attr)(name)
else:
setattr(self._get_service(serv), attr, name)
def set_name(self, service, name):
"""Set the desired name for the specified service.
:param str service: Service type.
:param str name: Desired service name.
"""
if service == self.ALL:
services = self.service_names
else:
services = [service]
for service in services:
self._get_service(service).service_name = name
self._setattr_on_service(service, 'service_name', name)
def set_region(self, service, region):
"""Set the desired region for the specified service.
@ -124,12 +130,7 @@ class UserPreference(object):
:param str service: Service type.
:param str region: Desired service region.
"""
if service == self.ALL:
services = self.service_names
else:
services = [service]
for service in services:
self._get_service(service).region = region
self._setattr_on_service(service, 'region', region)
def set_version(self, service, version):
"""Set the desired version for the specified service.
@ -137,12 +138,7 @@ class UserPreference(object):
:param str service: Service type.
:param str version: Desired service version.
"""
if service == self.ALL:
services = self.service_names
else:
services = [service]
for service in services:
self._get_service(service).version = version
self._setattr_on_service(service, 'version', version)
def set_visibility(self, service, visibility):
"""Set the desired visibility for the specified service.
@ -150,9 +146,5 @@ class UserPreference(object):
:param str service: Service type.
:param str visibility: Desired service visibility.
"""
if service == self.ALL:
services = self.service_names
else:
services = [service]
for service in services:
self._get_service(service).set_visibility(visibility)
self._setattr_on_service(service, 'set_visibility', visibility,
is_callable=True)